Refine UI Kit Place Details Compact sample #1055
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the summary of changes. You are about to add 4 region tags.
You are about to delete 4 region tags.
This comment is generated by snippet-bot.
|
chrisjshull
requested changes
Jan 27, 2026
| <gmp-place-details-compact orientation="horizontal"> | ||
| <!--[START maps_ui_kit_place_details_compact_request]--> | ||
| <div class="container"> | ||
| <!-- map-id is required to use advanced markers. See https://developers.google.com/maps/documentation/javascript/map-ids/mapid-over. --> |
There was a problem hiding this comment.
Suggested change
| <!-- map-id is required to use advanced markers. See https://developers.google.com/maps/documentation/javascript/map-ids/mapid-over. --> | |
| <!-- map-id is required to use Advanced Markers. See https://developers.google.com/maps/documentation/javascript/map-ids/mapid-over. --> |
| The gmp-place-details-compact element is styled inline because it is | ||
| conditionally rendered and moved into the info window, which is | ||
| part of the map's shadow DOM. | ||
| --> |
| <!-- map-id is required to use advanced markers. See https://developers.google.com/maps/documentation/javascript/map-ids/mapid-over. --> | ||
| <gmp-map | ||
| center="47.759737, -122.250632" | ||
| zoom="16" |
There was a problem hiding this comment.
suggest leaving off the center and zoom, as the fitBounds() call later will cover that (and that would avoid a transition post-load)
| 'maps' | ||
| )) as google.maps.MapsLibrary; | ||
| // Request needed libraries. | ||
| await Promise.all([ |
There was a problem hiding this comment.
Suggested change
| await Promise.all([ | |
| Promise.all([ |
I think we can tweak this to avoid strictly blocking on all these things up front
| )) as google.maps.MarkerLibrary; | ||
| gMap = new Map(mapContainer, { mapId: 'DEMO_MAP_ID' }); | ||
| marker = new AdvancedMarkerElement({ map: gMap }); | ||
| // Set the map options. |
There was a problem hiding this comment.
Suggested change
| // Set the map options. | |
| await window.customElements.whenDefined('gmp-map'); | |
| // Set the map options. |
| placeDetailsRequest.place = event.placeId; | ||
| updateMapAndMarker(); | ||
| } else { | ||
| // Fire when the user clicks the map (not on a POI). |
There was a problem hiding this comment.
Suggested change
| // Fire when the user clicks the map (not on a POI). | |
| // When the user clicks the map (not on a POI). |
| if (event.placeId) { | ||
| console.log('clicked on POI'); | ||
| console.log(event.placeId); | ||
| // Fire when the user clicks a POI. |
There was a problem hiding this comment.
Suggested change
| // Fire when the user clicks a POI. | |
| // When the user clicks a POI. |
| } else { | ||
| // Fire when the user clicks the map (not on a POI). | ||
| console.log('No place was selected.'); | ||
| marker.style.display = 'none'; |
There was a problem hiding this comment.
Suggested change
| marker.style.display = 'none'; |
| // Fire when the user clicks the map (not on a POI). | ||
| console.log('No place was selected.'); | ||
| marker.style.display = 'none'; | ||
| infoWindow.close(); |
There was a problem hiding this comment.
Suggested change
| infoWindow.close(); |
should happen automatically because it's attached to the marker
| console.log(event.placeId); | ||
| // Fire when the user clicks a POI. | ||
| placeDetailsRequest.place = event.placeId; | ||
| updateMapAndMarker(); |
There was a problem hiding this comment.
Suggested change
| updateMapAndMarker(); |
I think remove this here, and just let gmp-load on the details view trigger it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.