Fix Import Path Normalization + Getting Started Examples#3
Open
ifedayoprince wants to merge 2 commits intogorango:masterfrom
Open
Fix Import Path Normalization + Getting Started Examples#3ifedayoprince wants to merge 2 commits intogorango:masterfrom
ifedayoprince wants to merge 2 commits intogorango:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces two key improvements:
1. Fix: Normalize all generated import paths to POSIX forward-slash format
The Flowcraft compiler previously relied on
path.relative()to generate import paths.On Windows, this produced backslash (
\) separators, which resulted in invalid ESM import statements such as:ESM imports must use POSIX forward slashes (
/).This PR ensures all generated import paths are normalized to
path.posixformat, making builds consistent across platforms.2. Fix: Correct syntax + build errors in Getting Started documentation
The examples in the Getting Started page contained minor issues that prevented them from working out-of-the-box.
This PR updates the examples to:
This ensures the first user experience with Flowcraft is smooth and error-free.
The previous documentation examples failed to compile repeatedly.
Just trying out Flowcraft. Nice project!