Skip to content

Conversation

@logistic-bot
Copy link

Closes #270

Also added an indicator to show which profile is currently being worked on. This is currently shown even if only one profile is being update

Closes gorilla-devs#270

Also added an indicator to show which profile is currently being worked
on. This is currently shown even if only one profile is being update
@CLAassistant
Copy link

CLAassistant commented Feb 14, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@logistic-bot
Copy link
Author

This is my first contribution to open source, I hope I did everything correctly.

@tippfehlr
Copy link

While testing this I noticed that it tries to upgrade all profiles, even if there are in the same mod folder, which doesn’t make sense because the freshly upgraded files are removed instantly when upgrading the next profile. There needs to be a check so that only profiles that are in another mod directory are upgraded too. That’s the next problem though: We have no way of knowing which profile is supposed to be active in other directories. (#322)

@theRookieCoder planned to add this with #163, so I don’t think it is necessary to update this.

@theRookieCoder
Copy link
Collaborator

While testing this I noticed that it tries to upgrade all profiles, even if there are in the same mod folder, which doesn’t make sense because the freshly upgraded files are removed instantly when upgrading the next profile

Hmm yes valid point.

There needs to be a check so that only profiles that are in another mod directory are upgraded too

I will consider this when implementing the feature. My plan is to warn or not allow the user to add profiles that output to the same directory, and suggest that they use multiple launcher profiles as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade all profiles ability

4 participants