Fix: Add HTTP error handling to prevent download hangs #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When download requests receive HTTP error responses (like 429, 503, etc.), the code was previously waiting indefinitely for chunks that would never arrive. This adds response.error_for_status_ref()? to immediately fail with a clear error message when the server returns an error status code. Fixes issue where modpack downloads would hang at 0 B/s indefinitely.
|
|
Author
|
Signed! Thank you for providing such a neat application. I'm looking forward to new features! |
Author
|
sorry i didnt mean to close the pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Downloads would hang indefinitely at 0 B/s when the server returned HTTP error responses.
Solution
Added
response.error_for_status_ref()?to check HTTP status codes before attempting to read response chunks.idunno
I'm not sure why this worked, but my best guess would be that the error handling just re-requested the site downloads and allowed the download to take place.
Testing
Successfully tested with a 510MB modpack download (258 files) that previously hung.