Conversation
lmeyerov
reviewed
Jul 30, 2024
| ./prepopulate-notebooks.sh graph-app-kit/public views ubuntu | ||
| ./prepopulate-notebooks.sh graph-app-kit/private views ubuntu | ||
| ./graphistry-wait-healthy.sh | ||
| ./swap-caddy.sh |
Contributor
There was a problem hiding this comment.
I think almost all of this file can go away as Graphistry has gak pub/priv built in, in unclear what's left here?
lmeyerov
requested changes
Jul 30, 2024
Contributor
lmeyerov
left a comment
There was a problem hiding this comment.
Thanks!
- See comments. I'm esp unclear if / what needs to remain in Graphistry.sh, or if we can replace that cfm with a raw AMI?
- When ready, we should test minimal + bundles modes
- Let's get this out, and after next release, update AMI list again, maybe have someone else learn the flow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: src/bootstraps/core/graphistry.yml and related need to be updated to latest AMI IDs and they need to be copied to other regions: