Implement changes from code review #2308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [motion](https://redirect.github.com/motiondivision/motion) | [`12.23.26` → `12.26.2`](https://renovatebot.com/diffs/npm/motion/12.23.26/12.26.2) |  |  | --- ### Release Notes <details> <summary>motiondivision/motion (motion)</summary> ### [`v12.26.2`](https://redirect.github.com/motiondivision/motion/blob/HEAD/CHANGELOG.md#12262-2026-01-13) [Compare Source](https://redirect.github.com/motiondivision/motion/compare/v12.26.1...v12.26.2) ##### Fixed - Internal refactor of projection system into `motion-dom`. ### [`v12.26.1`](https://redirect.github.com/motiondivision/motion/blob/HEAD/CHANGELOG.md#12261-2026-01-12) [Compare Source](https://redirect.github.com/motiondivision/motion/compare/v12.26.0...v12.26.1) ##### Fixed - Improve overload selection for `useTransform`. ### [`v12.26.0`](https://redirect.github.com/motiondivision/motion/blob/HEAD/CHANGELOG.md#12260-2026-01-12) [Compare Source](https://redirect.github.com/motiondivision/motion/compare/v12.25.0...v12.26.0) ##### Added - Support for multiple output value maps with `useTransform`. ### [`v12.25.0`](https://redirect.github.com/motiondivision/motion/blob/HEAD/CHANGELOG.md#12250-2026-01-09) [Compare Source](https://redirect.github.com/motiondivision/motion/compare/v12.24.12...v12.25.0) ##### Added - Support for auto-scrolling when a `Reorder.Item` reaches the edges of its parent scrollable container. ### [`v12.24.12`](https://redirect.github.com/motiondivision/motion/blob/HEAD/CHANGELOG.md#122412-2026-01-08) [Compare Source](https://redirect.github.com/motiondivision/motion/compare/v12.24.11...v12.24.12) ##### Fixed - Draggable elements now track pointer during page and element scroll. ### [`v12.24.11`](https://redirect.github.com/motiondivision/motion/blob/HEAD/CHANGELOG.md#122411-2026-01-08) [Compare Source](https://redirect.github.com/motiondivision/motion/compare/v12.24.10...v12.24.11) ##### Fixed - Fixed time sampling of GPU animations under heavy CPU load. ### [`v12.24.10`](https://redirect.github.com/motiondivision/motion/compare/v12.24.9...v12.24.10) [Compare Source](https://redirect.github.com/motiondivision/motion/compare/v12.24.9...v12.24.10) ### [`v12.24.9`](https://redirect.github.com/motiondivision/motion/blob/HEAD/CHANGELOG.md#12249-2026-01-07) [Compare Source](https://redirect.github.com/motiondivision/motion/compare/v12.24.8...v12.24.9) ##### Fixed - Fixing Radix `Dialog` with `AnimatePresence`. - Ensure drag constraints animation resumes after press interruption. - Prevent drag gesture from triggering when pressing focusable elements. ### [`v12.24.8`](https://redirect.github.com/motiondivision/motion/blob/HEAD/CHANGELOG.md#12248-2026-01-07) [Compare Source](https://redirect.github.com/motiondivision/motion/compare/v12.24.7...v12.24.8) ##### Fixed - Perform unit conversion when animating to/from `calc()` values. ### [`v12.24.7`](https://redirect.github.com/motiondivision/motion/blob/HEAD/CHANGELOG.md#12247-2026-01-06) [Compare Source](https://redirect.github.com/motiondivision/motion/compare/v12.24.6...v12.24.7) ##### Fixed - Fix duplicate exit animations in `AnimatePresence`. ### [`v12.24.6`](https://redirect.github.com/motiondivision/motion/blob/HEAD/CHANGELOG.md#12246-2026-01-06) [Compare Source](https://redirect.github.com/motiondivision/motion/compare/v12.24.5...v12.24.6) ##### Fixed - Remove memory leak from retained `matchMedia` callbacks. ### [`v12.24.5`](https://redirect.github.com/motiondivision/motion/blob/HEAD/CHANGELOG.md#12245-2026-01-06) [Compare Source](https://redirect.github.com/motiondivision/motion/compare/v12.24.4...v12.24.5) ##### Fixed - Prevent `ref` access error for `AnimatePresence` `popLayout` mode in React 19. ### [`v12.24.4`](https://redirect.github.com/motiondivision/motion/blob/HEAD/CHANGELOG.md#12244-2026-01-06) [Compare Source](https://redirect.github.com/motiondivision/motion/compare/v12.24.3...v12.24.4) ##### Fixed - Support `ref` functions that return a cleanup callback. ### [`v12.24.3`](https://redirect.github.com/motiondivision/motion/blob/HEAD/CHANGELOG.md#12243-2026-01-06) [Compare Source](https://redirect.github.com/motiondivision/motion/compare/v12.24.2...v12.24.3) ##### Fixed - Ensure `onAnimationStart` and `onAnimationComplete` callbacks fire for `useSpring`. ### [`v12.24.2`](https://redirect.github.com/motiondivision/motion/blob/HEAD/CHANGELOG.md#12242-2026-01-06) [Compare Source](https://redirect.github.com/motiondivision/motion/compare/v12.24.1...v12.24.2) ##### Fixed - Ensure `useDragControls `snapToCursor: true\` works with initial transforms. ### [`v12.24.1`](https://redirect.github.com/motiondivision/motion/blob/HEAD/CHANGELOG.md#12241-2026-01-06) [Compare Source](https://redirect.github.com/motiondivision/motion/compare/v12.24.0...v12.24.1) ##### Fixed - Ensure CSS Motion Path properties are applied via `style` on SVG elements. - Ensure `JSX` is correctly imported by `Reorder.Item`. ### [`v12.24.0`](https://redirect.github.com/motiondivision/motion/blob/HEAD/CHANGELOG.md#12240-2026-01-05) [Compare Source](https://redirect.github.com/motiondivision/motion/compare/v12.23.28...v12.24.0) ##### Added - `{ type: "svg" }` option to `motion.create()` for creating custom SVG components. - `px` default value type for CSS logical properties (`paddingBlock`, `paddingInline`, `marginBlock`, `marginInline`). ##### Fixed - Ensure drag gesture updates with latest props every render. - Fix missing `JSX` import error. - Fix `motion-dom` build. - Exclude `src` from distributed package. ### [`v12.23.28`](https://redirect.github.com/motiondivision/motion/blob/HEAD/CHANGELOG.md#122328-2026-01-05) [Compare Source](https://redirect.github.com/motiondivision/motion/compare/v12.23.27...v12.23.28) ##### Fixed - Fixing `MotionStyle` type with React 19 when `skipLibCheck` is `false`. - Add guard for `process` check for better compat with ESM environments. ### [`v12.23.27`](https://redirect.github.com/motiondivision/motion/blob/HEAD/CHANGELOG.md#122327-2026-01-05) [Compare Source](https://redirect.github.com/motiondivision/motion/compare/v12.23.26...v12.23.27) ##### Fixed - Improved Intellisense detection for `motion` import. - Adding sourcemaps to release. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/graphql/graphql.github.io). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi43NC41IiwidXBkYXRlZEluVmVyIjoiNDIuNzQuNSIsInRhcmdldEJyYW5jaCI6InNvdXJjZSIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ql#2298) This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [@graphql-tools/schema](https://redirect.github.com/ardatan/graphql-tools) ([source](https://redirect.github.com/ardatan/graphql-tools/tree/HEAD/packages/schema)) | [`10.0.30` → `10.0.31`](https://renovatebot.com/diffs/npm/@graphql-tools%2fschema/10.0.30/10.0.31) |  |  | --- ### Release Notes <details> <summary>ardatan/graphql-tools (@​graphql-tools/schema)</summary> ### [`v10.0.31`](https://redirect.github.com/ardatan/graphql-tools/blob/HEAD/packages/schema/CHANGELOG.md#10031) [Compare Source](https://redirect.github.com/ardatan/graphql-tools/compare/@graphql-tools/schema@10.0.30...@graphql-tools/schema@10.0.31) ##### Patch Changes - Updated dependencies \[[`6f3776c`](https://redirect.github.com/ardatan/graphql-tools/commit/6f3776c06e80aa6b793be9742e9b2453f8746276)]: - [@​graphql-tools/utils](https://redirect.github.com/graphql-tools/utils)@​11.0.0 - [@​graphql-tools/merge](https://redirect.github.com/graphql-tools/merge)@​9.1.7 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/graphql/graphql.github.io). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi43NC41IiwidXBkYXRlZEluVmVyIjoiNDIuNzQuNSIsInRhcmdldEJyYW5jaCI6InNvdXJjZSIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
## Description Hey @jemgillam I noticed the contrast on the links in the SME posts in light mode is a bit low (i.e. below WCAG 1.4.3 Criterion). <img width="316" height="243" alt="image" src="https://github.com/user-attachments/assets/f435eb23-a85f-4bf8-bf5c-ceb647b0aaa8" /> ### Solution I'd like to propose using the same button `Button` we use on the landing pages in the blogs, like this: ```tsx import { Button } from "@/app/conf/_design-system/button"; <Button href="https://*" /> // renders HTMLAnchorElement with `target="_blank" rel="noreferrer"` ```
|
@benjie is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
benjie
added a commit
that referenced
this pull request
Jan 19, 2026
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jem <6413628+jemgillam@users.noreply.github.com> Co-authored-by: Piotr Monwid-Olechnowicz <hasparus@gmail.com> Co-authored-by: Benjie Gillam <benjie@jemjie.com>
benjie
added a commit
that referenced
this pull request
Jan 19, 2026
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jem <6413628+jemgillam@users.noreply.github.com> Co-authored-by: Piotr Monwid-Olechnowicz <hasparus@gmail.com> Co-authored-by: Benjie Gillam <benjie@jemjie.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement's @benjie's feedback on #2303