feat(search): make search panel semi-transparent when overlapping active search match #937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
d3m1d0v
force-pushed
the
search-panel-opacity
branch
from
f280d3b to
40df37c
Compare
Collaborator
|
I suggest we test performance on a large document before and after this change. Run: turn on search, then quickly press next/prev and do scroll/resize, so the popup overlaps the active match. We can check for FPS drops (does it stay at 60) and for UI lag/stutters |
makhnatkin
approved these changes
Jan 27, 2026
d3m1d0v
force-pushed
the
search-panel-opacity
branch
from
40df37c to
35e20bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.