Skip to content

fix(coding-standard)!: use magento/php-compatibility-fork #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
damienwebdev merged 2 commits into from
Apr 9, 2025
Merged

fix(coding-standard)!: use magento/php-compatibility-fork #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8c998e
fix(coding-standard): use magento/php-compatibility-fork
damienwebdev Apr 9, 2025
d3607bf
docs: document compatability
damienwebdev Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions coding-standard/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

A Github Action that runs the Magento Coding Standard.

> [!WARNING]
> This action is only compatible with Magento v2.4.4+.

## Inputs

See the [action.yml](./action.yml)
Expand Down
2 changes: 1 addition & 1 deletion coding-standard/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ runs:
- name: Register Coding Standard
shell: bash
working-directory: standard
run: vendor/bin/phpcs --config-set installed_paths ${{ github.workspace }}/standard/vendor/magento/magento-coding-standard,${{ github.workspace }}/standard/vendor/phpcompatibility/php-compatibility
run: vendor/bin/phpcs --config-set installed_paths ${{ github.workspace }}/standard/vendor/magento/magento-coding-standard,${{ github.workspace }}/standard/vendor/magento/php-compatibility-fork

- name: Set ignore warnings flag
shell: bash
Expand Down