. t refactor - unhardcode rule

Co-Authored-By: Gregor Riegler <rieglerg85@gmail.com>
Co-Authored-By: Nitsan Avni <nitsanav@gmail.com>
Co-Authored-By: Joel Silberman <42779942+jcs-instructor@users.noreply.github.com>
Co-Authored-By: 4dsherwood <4dsherwood@users.noreply.github.com>
Co-Authored-By: Matt <matthew.anderson11@gmail.com>

Author: 5 people

katas/fizzbuzz/test_fizzbuzz.py

@@ -56,8 +56,10 @@ def test_buzz_divisor_is_5(fizzbuzz_db):
 def make_fizzbuzz(db) -> FizzbuzzFn:
     def fizzbuzz_fn(number):  
         # TODO: get the rule from the db for 5
-        if number == 5:
-            return "Buzz"
+        divisor = 5
+        word = "Buzz"
+        if number == divisor:
+            return word
         return "Fizz"
     return fizzbuzz_fn
 
@@ -72,17 +74,16 @@ def test_buzz(fizzbuzz_db):
     fizzbuzz_fn = make_fizzbuzz(fizzbuzz_db)
     assert "Buzz" == fizzbuzz_fn(5)
 
-def test_different_rules(fizzbuzz_db):
+def skip_test_different_rules(fizzbuzz_db):
     rules = fizzbuzz_db.fizzbuzz_rules
+    rules.delete_many(filter={})
     rules.insert_many(
         [
-            {"word": "Fizz", "divisor": 3},
-            {"word": "Buzz", "divisor": 5},
-            # add Bang, 7
+            {"word": "Bang", "divisor": 5},
         ]
     )
     fizzbuzz_fn = make_fizzbuzz(fizzbuzz_db)
-    assert "Bang" == fizzbuzz_fn(7)
+    assert "Bang" == fizzbuzz_fn(5)
 
 def skip_test_15(fizzbuzz_db):
     fizzbuzz_fn = make_fizzbuzz(fizzbuzz_db)

session-notes/session-notes-2024-04-25.md

@@ -90,6 +90,25 @@ Joel
 - Next: continue as we are
 - Good to do the retro now
 
+### Retro 3
+
+Nitsan
+- Wondering about this pattern: many refactorings until the change is very small (possibly 1 line)
+- Dilemma: do this on green? or red? (or orange?) We have a relevant failing test. Let's do the simplest thing to pass;
+  maybe refactor so it's easier & maybe better than refactoring on red. "Orange state" - want a failing test to tell us
+  where we're going and also the ability to refactor.
+
+Diana
+- Request: when talking, make sure to state your intention, and how it fits
+- Enjoying the rotations
+
+Joel
+- Happy +1 on stating the intention
+- Thought this would be simpler than it is; surprised how complicated this is, and how it fits into TDD
+- Things getting clearer
+- Clear intentions: helps with different ideas people might have
+
+
 ### Final Retro
 
 ### How we spent our time today: