Skip to content

Conversation

@grillazz
Copy link
Owner

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the test fixture infrastructure to improve test isolation and database transaction handling. It introduces a new db_session fixture with explicit transaction management and updates test files to use direct database manipulation where appropriate.

Changes:

  • Introduced per-test db_session fixture with transaction rollback for improved test isolation
  • Updated test fixtures to use explicit dependency overrides with the new session management
  • Removed unused POSTGRES_TEST_USER environment variable from configuration
  • Disabled SQL echo logging for the test engine to reduce test output verbosity

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tests/conftest.py Refactored test fixtures: added db_session fixture with transaction management, made start_db autouse, updated client fixture to use dependency override with db_session
tests/api/test_stuff.py Updated tests to accept db_session parameter and use direct database manipulation instead of HTTP calls for test data setup
app/database.py Disabled SQL echo logging (echo=False) for test engine to reduce verbosity during test execution
app/config.py Removed unused POSTGRES_TEST_USER field from Settings class
.env Removed unused POSTGRES_TEST_USER environment variable

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@grillazz grillazz merged commit ab7dd25 into main Jan 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants