Skip to content

Internal api bugfix fix #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandon-wada merged 8 commits into from
Dec 12, 2024
Merged

Internal api bugfix fix #297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b5e35ec
Consider the async case for internal functions
Dec 12, 2024
8329ae2
hotfix
Dec 12, 2024
73f97b6
Merge branch 'main' into internal_api_bugfix_fix
Dec 12, 2024
20ab3d2
Automatically reformatting code
Dec 12, 2024
1f03ec9
ruff fix
Dec 12, 2024
664d66d
Merge branch 'internal_api_bugfix_fix' of github.com:groundlight/pyth…
Dec 12, 2024
0899dc7
test fix related to multiclass
Dec 12, 2024
5e5d864
Automatically reformatting code
Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion test/integration/test_groundlight.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
CountingResult,
Detector,
ImageQuery,
MultiClassificationResult,
PaginatedDetectorList,
PaginatedImageQueryList,
)
Expand All @@ -30,7 +31,11 @@

def is_valid_display_result(result: Any) -> bool:
"""Is the image query result valid to display to the user?."""
if not isinstance(result, BinaryClassificationResult) and not isinstance(result, CountingResult):
if (
not isinstance(result, BinaryClassificationResult)
and not isinstance(result, CountingResult)
and not isinstance(result, MultiClassificationResult)
):
return False
if not is_valid_display_label(result.label):
return False
Expand Down
4 changes: 2 additions & 2 deletions test/unit/test_internalapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@

def test_iq_is_confident(gl_experimental: ExperimentalApi):
det = gl_experimental.get_or_create_detector("Test", "test_query")
iq = gl_experimental.ask_async(det, image="test/assets/dog.jpeg", wait=10)
iq = gl_experimental.ask_async(det, image="test/assets/dog.jpeg")
assert not iq_is_confident(iq, 0.9)


def test_iq_is_answered(gl_experimental: ExperimentalApi):
det = gl_experimental.get_or_create_detector("Test", "test_query")
iq = gl_experimental.ask_async(det, image="test/assets/dog.jpeg", wait=10)
iq = gl_experimental.ask_async(det, image="test/assets/dog.jpeg")
assert not iq_is_answered(iq)