-
Notifications
You must be signed in to change notification settings - Fork 4k
otel: add tcp metrics #12652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AgraVator
wants to merge
8
commits into
grpc:master
Choose a base branch
from
AgraVator:tcp-metrics
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+760
−16
Open
otel: add tcp metrics #12652
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
508c141
otel: add tcp metrics
AgraVator 5ef3b1c
add optional labels
AgraVator c4111e2
tcp: add jitter
AgraVator 172f6c4
tcp: add null check
AgraVator 6996afd
fix test
AgraVator 42a834b
increase coverage
AgraVator 65487c6
formatting changes
AgraVator 2b44889
add missing metric collection when channel becomes inactive
AgraVator File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,6 +31,7 @@ | |
| import io.grpc.InternalInstrumented; | ||
| import io.grpc.InternalLogId; | ||
| import io.grpc.InternalWithLogId; | ||
| import io.grpc.MetricRecorder; | ||
| import io.grpc.ServerStreamTracer; | ||
| import io.grpc.internal.InternalServer; | ||
| import io.grpc.internal.ObjectPool; | ||
|
|
@@ -93,6 +94,7 @@ class NettyServer implements InternalServer, InternalWithLogId { | |
| private final int maxMessageSize; | ||
| private final int maxHeaderListSize; | ||
| private final int softLimitHeaderListSize; | ||
| private MetricRecorder metricRecorder; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How is this being set? I don't see a constructor or a setter that accesses this value? |
||
| private final long keepAliveTimeInNanos; | ||
| private final long keepAliveTimeoutInNanos; | ||
| private final long maxConnectionIdleInNanos; | ||
|
|
@@ -272,7 +274,8 @@ public void initChannel(Channel ch) { | |
| permitKeepAliveTimeInNanos, | ||
| maxRstCount, | ||
| maxRstPeriodNanos, | ||
| eagAttributes); | ||
| eagAttributes, | ||
| metricRecorder); | ||
| ServerTransportListener transportListener; | ||
| // This is to order callbacks on the listener, not to guard access to channel. | ||
| synchronized (NettyServer.this) { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you review go/java-practices/null from the overall PR's perspective in terms of nullable vs optional ? I am not sure if we have a local java convention to prefer or avoid null