Skip to content

fix: make_latest must be a string #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ruromero merged 1 commit into from
Apr 10, 2025
Merged

fix: make_latest must be a string #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:
steps:

- name: Create release notes for ${{ needs.deploy.outputs.project_version }} release
uses: actions/github-script@v6
uses: actions/github-script@v7
id: release-notes
with:
github-token: ${{ secrets.STAGING_PAT }}
Expand All @@ -91,7 +91,7 @@ jobs:
return response.data.body

- name: Create new ${{ needs.deploy.outputs.project_version }} release
uses: actions/github-script@v6
uses: actions/github-script@v7
with:
github-token: ${{ secrets.STAGING_PAT }}
script: |
Expand Down
26 changes: 18 additions & 8 deletions .github/workflows/stage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
steps:
- name: Check for existing ${{ needs.deploy.outputs.project_version }} release
id: existing_release
uses: actions/github-script@v6
uses: actions/github-script@v7
env:
PROJECT_VERSION: ${{ needs.deploy.outputs.project_version }}
continue-on-error: true
Expand Down Expand Up @@ -93,12 +93,22 @@ jobs:
script: |
const repo = context.repo;
const releaseId = process.env.RELEASE_ID;
await github.rest.repos.deleteRelease({
owner: repo.owner,
repo: repo.repo,
release_id: releaseId
});

try {
console.log(`Deleting release ID: ${releaseId}`);
await github.rest.repos.deleteRelease({
owner: repo.owner,
repo: repo.repo,
release_id: releaseId
});
console.log(`Deleted release ID: ${releaseId}`);
} catch (error) {
if (error.status === 404) {
console.log(`Release ID: ${releaseId} not found. Skipping deletion.`);
} else {
throw error;
}
}
- name: Delete ${{ needs.deploy.outputs.project_version }} tag if exists
continue-on-error: true
run: git push --delete origin ${{ needs.deploy.outputs.project_version }}
Expand All @@ -108,7 +118,7 @@ jobs:
run: sleep 5

- name: Create new ${{ needs.deploy.outputs.project_version }} release
uses: actions/github-script@v6
uses: actions/github-script@v7
env:
PROJECT_VERSION: ${{ needs.deploy.outputs.project_version }}
with:
Expand All @@ -127,7 +137,7 @@ jobs:
draft: false,
prerelease: true,
generate_release_notes: true,
make_latest: false,
make_latest: 'false',
});

console.log(`Release created: ${response.data.html_url}`);
Loading