feat: accept customized Maven user settings file and local repository. #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The CI failures depend on #181 |
Contributor
Author
|
@ruromero Could you approve this, so I can merge it. |
ruromero
requested changes
Oct 21, 2025
Collaborator
ruromero
left a comment
ruromero
left a comment
There was a problem hiding this comment.
Add also to the documentation the 2 new env vars you are adding so that users can know they exist and how to use them. If you don't mind I'd shorten them to the following:
EXHORT_MVN_USER_SETTINGS
EXHORT_MVN_LOCAL_REPO
Signed-off-by: Chao Wang <chaowan@redhat.com>
Signed-off-by: Chao Wang <chaowan@redhat.com>
soul2zimate
force-pushed
the
maven_customized_config_main
branch
from
f6673bb to
dc20d2d
Compare
Contributor
Author
|
updated as per review comment. Thanks @ruromero |
ruromero
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: accept customized Maven user settings file and local repository.
Related issue (if any): redhat-developer/intellij-dependency-analytics#218
intellij-dependency-analytics PR: redhat-developer/intellij-dependency-analytics#220
Checklist