Skip to content

fix: use http-proxy-agent #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ruromero merged 1 commit into from
May 20, 2025
Merged

fix: use http-proxy-agent #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
"fast-toml": "^0.5.4",
"fast-xml-parser": "^4.2.4",
"help": "^3.0.2",
"https-proxy-agent": "^7.0.6",
"node-fetch": "^2.6.7",
"packageurl-js": "^1.0.2",
"yargs": "^17.7.2"
Expand Down
8 changes: 2 additions & 6 deletions src/analysis.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import fs from "node:fs";
import path from "node:path";
import {EOL} from "os";

Check warning on line 3 in src/analysis.js

View workflow job for this annotation

GitHub Actions / Lint and test project (latest) 

Imports should be sorted alphabetically

Check warning on line 3 in src/analysis.js

View workflow job for this annotation

GitHub Actions / Lint and test project (18) 

Imports should be sorted alphabetically
import {RegexNotToBeLogged, getCustom} from "./tools.js";

Check warning on line 4 in src/analysis.js

View workflow job for this annotation

GitHub Actions / Lint and test project (latest) 

Expected 'multiple' syntax before 'single' syntax

Check warning on line 4 in src/analysis.js

View workflow job for this annotation

GitHub Actions / Lint and test project (18) 

Expected 'multiple' syntax before 'single' syntax
import http from 'node:http';
import https from 'node:https';
import { HttpsProxyAgent } from "https-proxy-agent";

export default { requestComponent, requestStack, validateToken }

Expand All @@ -20,10 +19,7 @@
function addProxyAgent(options, opts) {
const proxyUrl = getCustom('EXHORT_PROXY_URL', null, opts);
if (proxyUrl) {
const proxyUrlObj = new URL(proxyUrl);
options.agent = proxyUrlObj.protocol === 'https:'
? new https.Agent({ proxy: proxyUrl })
: new http.Agent({ proxy: proxyUrl });
options.agent = new HttpsProxyAgent(proxyUrl);
}
return options;
}
Expand Down
Loading