Skip to content

Conversation

@soul2zimate
Copy link
Contributor

fixes: #544

chore: decommission OnGuard service from DA backend

Should I also remove the osv data from reportXXX.mock.ts for UI mocks?

@soul2zimate soul2zimate requested a review from ruromero December 11, 2025 14:32
@ruromero
Copy link
Collaborator

Yes but bear in mind that there are mocked responses for trustify/osv

Copy link
Collaborator

@ruromero ruromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one remark. the rest should be fine

@soul2zimate
Copy link
Contributor Author

Yes but bear in mind that there are mocked responses for trustify/osv

sure, I removed standalone OSV provider and preserved Trustify/OSV responses from mocked reports

@soul2zimate soul2zimate requested a review from ruromero December 12, 2025 02:50
Copy link
Collaborator

@ruromero ruromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @soul2zimate

@ruromero ruromero added the hold Something needs to block this issue from merging label Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold Something needs to block this issue from merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decommission OnGuard service from DA backend

2 participants