1918 fix frontend build action

[lcchrty]

Fixes #1918

What changes did you make and why did you make them ?

• Applied changes from 1497-incubator branch h/t @ale210
• The updated workflow:
  • modernizes the GitHub Actions jobs
  • provides enhanced security practices by assuming roles rather than using secrets
  • Simplifies jobs and steps to remove

[JackHaeg]

@trillium Please review this PR whenever you have a moment :) Once fixed, then we should potentially rebuild PROD with the latest feature updates for Bonnie to review on Thursday's call.

[lcchrty]

@JackHaeg @trillium Alex (@ale210) on the DevOps team is working on migrating the prod env as well, so it may be worth it to sync with him!

[trillium]

Hey hey, stoked that this is working, there's a knick-knack or two that need to be addressed though, please see comments.

I see that the deploy works though (re checking out the actions) thank you!!!

[trillium]

Pretty sure this is a typo

[lcchrty]

Yep! fixed.

[JackHaeg]

@lcchrty When you have a moment, can you please implement the changes requested by @trillium? Once complete, we can then rebuild Dev & (potentially) Prod as a test

[lcchrty]

@trillium @JackHaeg changes made and fingers crossed this is good to go!

[JackHaeg]

Thanks @lcchrty!!

@trillium can you please review this PR when you have a moment?

[JackHaeg]

@trillium Can you please review this PR this week to unblock rebuilding Dev / Prod?

[Copilot]

Pull Request Overview

This PR modernizes the frontend deployment workflow by switching to AWS OIDC role assumptions, updating naming and paths, and streamlining build/deploy steps.

• Switches aws-actions/configure-aws-credentials to v3 with OIDC role assumption and removes static secrets
• Updates AWS_APP_NAME and Dockerfile path, and consolidates Docker build into a custom shell step
• Replaces multiple ECS action steps with a single AWS CLI update-service call

Comments suppressed due to low confidence (3)

.github/workflows/aws-frontend-deploy.yml:18

• The Dockerfile path and build context may be mismatched: you cd into ${{ env.DOCKER_PATH }} (client) but reference Dockerfile.prod at the repo root. Either move the Dockerfile into the client directory or update DOCKER_PATH to . so the file is found in the build context.

  DOCKERFILE: Dockerfile.prod

.github/workflows/aws-frontend-deploy.yml:63

• Consider using the ${{ env.AWS_REGION }} variable here instead of hardcoding us-west-2, to keep region configuration consistent and centralized.

          aws-region: us-west-2

.github/workflows/aws-frontend-deploy.yml:73

• [nitpick] The ls command appears to be leftover debugging output and isn’t required for the build step. Removing it will clean up the workflow logs.

          ls

[trillium]

Approved!

Thanks for getting this working again @lcchrty

[trillium]

Hey there, can you clarify which file you're pointing to here? I don't see a Dockerfile.prod in the base dir of the monorepo