Reopen Issues Without Linked PR #8438

myronchen-git · 2025-11-27T02:21:09Z

What changes did you make?

Created a new GitHub Actions workflow to check closed issues without any linked PRs or appropriate excusing labels, and reopen them.
Created a JavaScript file to store the main code to check a closed issue. This checks if there is a "non-PR contribution" label or a label containing the word "Ignore". If there aren't any of those labels, then this checks how many linked PRs there are.
Created a JavaScript file to store the main code for reopening the aforementioned issue, adding a "ready for product" label to it, changing the project status to "Questions / In Review" in it, and posting a comment explaining the reason in it.

Why did you make the changes (we will use this info to test)?

To prevent losing track of issues that were accidentally closed.
The checks for the "non-PR contribution" and "Ignore" labels are required for instances where the issues are not fixed through code or for issues that should be ignored.
In check-issue-labels-and-linked-prs.js, a direct GitHub GraphQL request is made instead of using the utility file find-linked-issue.js, because it queries GitHub for a direct number of linked PRs while the utility file only checks an issue's description through regex. This methodology should be more reliable.
Reopened issues are given a "ready for product" label and have their project status changed, because those help give visibility to the team.
Tests for reopen-issue.js are skipped, because that file does not contain any logic, other than rethrowing Errors.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

I have checked this PR for CodeQL alerts and none were found.
I found CodeQL alert(s), and (select one):
- I have resolved the CodeQL alert(s) as noted
- I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
- I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)

Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

No visual changes to the website

github-actions · 2025-11-27T02:21:31Z

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b myronchen-git-check-closed-issue-for-linked-pr-8139 gh-pages
git pull https://github.com/myronchen-git/website.git check-closed-issue-for-linked-pr-8139

myronchen-git · 2025-11-27T02:25:05Z

.github/workflows/check-closed-issue-for-linked-pr.yml

+        uses: actions/github-script@v8
+        id: reopen-issue
+        with:
+          github-token: ${{ secrets.HACKFORLA_GRAPHQL_TOKEN }}


I am not 100% sure that this is the correct token to use. This workflow does need project permission though.

myronchen-git · 2025-11-27T02:27:04Z

...-closed-issue-for-linked-pr/check-for-linked-issue/check-issue-labels-and-linked-prs.test.js

+        { name: 'good first issue' },
+        { name: 'size: 1pt' },


Testing for when issues have other labels as well.

myronchen-git · 2025-11-27T02:27:24Z

...-closed-issue-for-linked-pr/check-for-linked-issue/check-issue-labels-and-linked-prs.test.js

+        { name: 'good first issue' },
+        { name: 'size: 1pt' },


Testing for when issues have other labels as well.

myronchen-git · 2025-11-27T02:29:30Z

...-closed-issue-for-linked-pr/check-for-linked-issue/check-issue-labels-and-linked-prs.test.js

+    // Assert
+    expect(result).toBe(true);
+    expect(github.graphql).toHaveBeenCalledWith(
+      expect.stringContaining('query'),


Don't really care how the query is constructed, as long as it returns the number of linked PRs.

myronchen-git · 2025-11-27T02:29:53Z

...-closed-issue-for-linked-pr/check-for-linked-issue/check-issue-labels-and-linked-prs.test.js

+      // Assert
+      expect(result).toBe(false);
+      expect(github.graphql).toHaveBeenCalledWith(
+        expect.stringContaining('query'),


Don't really care how the query is constructed, as long as it returns the number of linked PRs.

t-will-gillis · 2025-12-01T17:26:58Z

@myronchen-git I think this was closed by mistake- the bot should have closed #8439 and didn't. Let me know if you think it is something else...

myronchen-git · 2025-12-01T23:21:54Z

@myronchen-git I think this was closed by mistake- the bot should have closed #8439 and didn't. Let me know if you think it is something else...

Understood. Thanks for fixing this.

Create workflow to check linked PR

4b1d399

github-project-automation bot added this to P: HfLA Website: Project Board Nov 27, 2025

github-project-automation bot moved this to PR Needs review in P: HfLA Website: Project Board Nov 27, 2025

HackforLABot mentioned this pull request Nov 27, 2025

Skills Issue: Developer: Myron Chen #8274

Open

myronchen-git commented Nov 27, 2025

View reviewed changes

HackforLABot closed this Dec 1, 2025

t-will-gillis reopened this Dec 1, 2025

HackforLABot mentioned this pull request Dec 1, 2025

Pre-work Checklist: Developer: Will Gillis #3613

Open

34 tasks

t-will-gillis mentioned this pull request Dec 1, 2025

ER: Bug fix for "Schedule Monthly" workflow #8441

Open

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Reopen Issues Without Linked PR #8438

Reopen Issues Without Linked PR #8438

myronchen-git commented Nov 27, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 27, 2025

Uh oh!

myronchen-git Nov 27, 2025

Uh oh!

myronchen-git Nov 27, 2025

Uh oh!

myronchen-git Nov 27, 2025

Uh oh!

myronchen-git Nov 27, 2025

Uh oh!

myronchen-git Nov 27, 2025

Uh oh!

t-will-gillis commented Dec 1, 2025 •

edited

Loading

Uh oh!

myronchen-git commented Dec 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Reopen Issues Without Linked PR #8438

Are you sure you want to change the base?

Reopen Issues Without Linked PR #8438

Conversation

myronchen-git commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes did you make?

Why did you make the changes (we will use this info to test)?

CodeQL Alerts

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Uh oh!

github-actions bot commented Nov 27, 2025

Uh oh!

myronchen-git Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

myronchen-git Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

myronchen-git Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

myronchen-git Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

myronchen-git Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

t-will-gillis commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

myronchen-git commented Dec 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

myronchen-git commented Nov 27, 2025 •

edited

Loading

t-will-gillis commented Dec 1, 2025 •

edited

Loading