-
-
Notifications
You must be signed in to change notification settings - Fork 844
Update Github handle for Santiago Vidal #8446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Github handle for Santiago Vidal #8446
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 12/12/2025 |
ldaws003
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Colombianah for your contribution. The commit looks well. You did the required changes of changing santisecco to santiseccovidal in the _projects/website.md file. No changes need to be done for the code but there is for the pull request message.
Please delete the this message at the top "Please note: You must be a member of the HFLA website team in order to create pull requests. Please see our page on how to join us as a member at HFLA: https://www.hackforla.org/getting-started. Delete this message if you joined this team via onboarding."
Also, there are visual changes to the website. Please add the screenshots of Santiago's profile picture on https://www.hackforla.org/projects/website before and after your changes.
|
Hey, good job in removing the message. The screenshot doesn't reflect the changes. To see what the profile picture is before you can go to https://www.hackforla.org/projects/website, and to see what the website is after your changes you should run website on your computer, making sure that you're on your branch, and go to http://localhost:4000/projects/website. Also make sure to re-request review again to make sure that future reviewers get a notification for any changes to your PR. |
|
Review ETA: EOD 12/17/2025 |
|
The screenshot has been updated as requested. Now waiting for a new PR review. Let me know if there's anything else you need. |
ldaws003
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Approved.
|
oh one thing, since you do have screenshots please remove this line |
|
Hi @Colombianah, everything looks correct, great job! The merge from and to branches have been correctly set. The issue has been correctly linked. Screenshots accurately reflect before and after changes. Code changes have been correctly made. |
Fixes #8423
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Screenshots of Proposed Changes To The Website:
Before
After
