Skip to content

Conversation

@Colombianah
Copy link
Member

@Colombianah Colombianah commented Dec 11, 2025

Fixes #8423

What changes did you make?

  • Updated Github Handle from 'santisecco' to 'santiseccovidal'
  • Updated profile picture link
  • Verified YAML formatting

Why did you make the changes (we will use this info to test)?

  • The contributor's Github handle had changed, so the previous link was no longer correct.
  • Updating the handle and profile picture ensures the website displays accurate and up-to-date contributor information.

CodeQL Alerts

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • [x ] I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)

Screenshots of Proposed Changes To The Website:

Before

Screenshot 2025-12-12 183205

After
image

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b Colombianah-update-Github-handle-8423 gh-pages
git pull https://github.com/Colombianah/website.git update-Github-handle-8423

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.5pt Can be done in 3 hours or less labels Dec 11, 2025
@ldaws003 ldaws003 self-requested a review December 12, 2025 19:59
@ldaws003
Copy link
Member

Review ETA: 12/12/2025
Availability: 2 - 5 PM

Copy link
Member

@ldaws003 ldaws003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Colombianah for your contribution. The commit looks well. You did the required changes of changing santisecco to santiseccovidal in the _projects/website.md file. No changes need to be done for the code but there is for the pull request message.

Please delete the this message at the top "Please note: You must be a member of the HFLA website team in order to create pull requests. Please see our page on how to join us as a member at HFLA: https://www.hackforla.org/getting-started. Delete this message if you joined this team via onboarding."

Also, there are visual changes to the website. Please add the screenshots of Santiago's profile picture on https://www.hackforla.org/projects/website before and after your changes.

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Dec 12, 2025
@ldaws003
Copy link
Member

Hey, good job in removing the message. The screenshot doesn't reflect the changes. To see what the profile picture is before you can go to https://www.hackforla.org/projects/website, and to see what the website is after your changes you should run website on your computer, making sure that you're on your branch, and go to http://localhost:4000/projects/website. Also make sure to re-request review again to make sure that future reviewers get a notification for any changes to your PR.

@gabbyjimenez gabbyjimenez self-requested a review December 16, 2025 19:51
@gabbyjimenez
Copy link
Member

gabbyjimenez commented Dec 16, 2025

Review ETA: EOD 12/17/2025
Availability: 4-7 PM Wednesday

@Colombianah Colombianah moved this from PRs being reviewed to PR Needs review in P: HfLA Website: Project Board Dec 17, 2025
@Colombianah
Copy link
Member Author

The screenshot has been updated as requested. Now waiting for a new PR review. Let me know if there's anything else you need.

@Colombianah Colombianah requested a review from ldaws003 December 17, 2025 03:54
Copy link
Member

@ldaws003 ldaws003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Approved.

@ldaws003
Copy link
Member

ldaws003 commented Dec 17, 2025

oh one thing, since you do have screenshots please remove this line No visual changes to the website. This update modifies backend data only. at the end of your PR comment.

@michael-4 michael-4 assigned michael-4 and unassigned michael-4 Dec 18, 2025
@gabbyjimenez
Copy link
Member

gabbyjimenez commented Dec 18, 2025

Hi @Colombianah, everything looks correct, great job! The merge from and to branches have been correctly set. The issue has been correctly linked. Screenshots accurately reflect before and after changes. Code changes have been correctly made.

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Dec 18, 2025
@t-will-gillis t-will-gillis merged commit 7af248a into hackforla:gh-pages Dec 19, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

Development

Successfully merging this pull request may close these issues.

Update Github handle for Santiago Vidal: Website

5 participants