Fix UITraitCollection.current.userInterfaceStyle returning incorrect values on Done button press#2133
Draft
Fix UITraitCollection.current.userInterfaceStyle returning incorrect values on Done button press#2133
Conversation
Co-authored-by: hackiftekhar <3831495+hackiftekhar@users.noreply.github.com>
Co-authored-by: hackiftekhar <3831495+hackiftekhar@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Wrong 'UITraitCollection.current.userInterfaceStyle' on pressing 'Done' button
Fix UITraitCollection.current.userInterfaceStyle returning incorrect values on Done button press
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Done button in IQKeyboardManager's toolbar was returning incorrect values for
UITraitCollection.current.userInterfaceStylein delegate methods liketextFieldDidEndEditing, while the Return key worked correctly.Root Cause
The issue occurred because the Done button action calls
resignFirstResponder()before invoking delegate methods, which changes the responder chain context and causesUITraitCollection.currentto lose the proper view controller context.Solution
Objective-C Version (Automatic Fix)
Modified the
doneAction:method inIQKeyboardManager.mto:performAsCurrentTraitCollection:to preserve trait collection context during delegate invocationSwift Version (Developer Utilities)
Added
IQKeyboardToolbarManager+TraitCollectionFix.swiftwith:performWithCurrentTraitCollectionutility method for developersUsage
Objective-C: No changes required - fix works automatically.
Swift: Wrap trait collection access in delegate methods:
Testing
To verify the fix:
userInterfaceStylevalueThe implementation ensures backward compatibility while providing a reliable solution for accessing trait collection information in keyboard delegate methods.
Fixes #2099.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.