Skip to content

HCK-11091: Move the log of the start to the studio #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chulanovskyi-bs merged 1 commit into from
May 15, 2025
Merged

HCK-11091: Move the log of the start to the studio #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions forward_engineering/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,6 @@ module.exports = {
},

applyToInstance(connectionInfo, logger, callback, app) {
logger.clear();
logger.log(
'info',
app.require('lodash').omit(connectionInfo, 'script', 'containerData'),
'connectionInfo',
connectionInfo.hiddenKeys,
);

const cockroachDBLogger = createLogger({
title: 'Apply to instance',
hiddenKeys: connectionInfo.hiddenKeys,
Expand Down
15 changes: 0 additions & 15 deletions reverse_engineering/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
'use strict';

const { createLogger } = require('./helpers/loggerHelper');
const cockroachDBService = require('./helpers/cockroachDBService');

Expand All @@ -15,8 +13,6 @@ module.exports = {
const sshService = app.require('@hackolade/ssh-service');

try {
logInfo('Test connection', connectionInfo, logger);

const cockroachDBLogger = createLogger({
title: 'Test connection instance log',
hiddenKeys: connectionInfo.hiddenKeys,
Expand All @@ -40,8 +36,6 @@ module.exports = {
const sshService = app.require('@hackolade/ssh-service');

try {
logInfo('Get databases', connectionInfo, logger);

const cockroachDBLogger = createLogger({
title: 'Get DB names',
hiddenKeys: connectionInfo.hiddenKeys,
Expand Down Expand Up @@ -69,8 +63,6 @@ module.exports = {
const sshService = app.require('@hackolade/ssh-service');

try {
logInfo('Get DB table names', connectionInfo, logger);

const cockroachDBLogger = createLogger({
title: 'Get DB collections names',
hiddenKeys: connectionInfo.hiddenKeys,
Expand Down Expand Up @@ -117,8 +109,6 @@ module.exports = {
const sshService = app.require('@hackolade/ssh-service');

try {
logger.log('info', data, 'Retrieve tables data:', data.hiddenKeys);

const cockroachDBLogger = createLogger({
title: 'Get DB collections data log',
hiddenKeys: data.hiddenKeys,
Expand Down Expand Up @@ -221,11 +211,6 @@ const prepareError = error => {
return error;
};

const logInfo = (step, connectionInfo, logger) => {
logger.clear();
logger.log('info', connectionInfo, 'connectionInfo', connectionInfo.hiddenKeys);
};

const orderPackages = packages => {
return packages.sort((packA, packB) => {
if (!packA.collectionName && !packB.collectionName) {
Expand Down