implement instrument similarities in front end#54
Open
Jamesren64 wants to merge 2 commits intoharmonydata:masterfrom
Open
implement instrument similarities in front end#54Jamesren64 wants to merge 2 commits intoharmonydata:masterfrom
Jamesren64 wants to merge 2 commits intoharmonydata:masterfrom
Conversation
✅ Deploy Preview for harmony-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add instrument-to-instrument similarity metrics (F1, Precision, Recall) to Results.
Pass through instrument_to_instrument_similarities in src/utilities/simplifyApi.js as instrumentSimilarities.
Render InstrumentSimilarities card in src/components/InstrumentSimilarities.js with percent formatting. Show card in src/components/Results.js when data exists.
Dependencies:
Backend must return instrument_to_instrument_similarities with { instrument_1_name, instrument_2_name, precision, recall, f1 }.
No new npm packages.
Fixes # (issue)
#43
Type of change
New feature (non-breaking change which adds functionality)
Testing
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Local end to end test.

Test Configuration
Checklist