Bundle assets using TH#77
Open
nikita-volkov wants to merge 6 commits intohaskell-github-trust:masterfrom
Open
Conversation
|
✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨ Bump @tibbe Can we get some more discussion around a TH solution? |
Collaborator
|
@23Skidoo is the current maintainer. My general feedback back when this was discussed is that using TH to embed files in a binary for the purpose of easy distribution is a stop gap measure. Systems need to be able to package and ship data files together with binaries. That said, I'm no longer the maintainer. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Judging by the amount of pain expressed on this tracker it doesn't really seem like avoidance of Template Haskell is a viable strategy.
This PR builds up on work done #13, fixing issues in it and synchronising with the latest updates on the "master" branch of "ekg".
In case this PR still gets rejected, at least it can serve as a ground to build up on in #66. My fork can also be depended on thru Stack for those searching for an immediate solution.