update Cabal-syntax bound to permit 3.16

[geekosaur]

We're preparing to release Cabal and Cabal-syntax 3.16. As per #309 we need hackage-security to be updated before we release.

[Mikolaj]

It seems this doesn't require a new release, but just a revision, right? If so, I can revise.

[ulysses4ever]

It seems so to me too. I think it's often the case.

[Mikolaj]

If there are no objections by then, I will merge and revise tomorrow.

[andreasabel]

Can we get some evidence this works with Cabal-3.16?
(The least would be someone stating here, "I tried it out successfully on my local machine".)

[Mikolaj]

@geekosaur said on Matrix "building patched hackage-security locally (I did this last couple times)", but let us wait until @geekosaur confirms it was with cabal HEAD and all tests passed.

[geekosaur]

I built it against cabal HEAD but didn't run tests. Is there an easy way to run tests locally, beyond just cabal test (I'm thinking CI tests)?

[geekosaur]

Test suite TestSuite: RUNNING...
hackage-security
  InMem
    testInMemInitialHasForUpdates:   OK
    testInMemNoUpdates:              OK
    testInMemUpdatesAfterCron:       OK
    testInMemKeyRollover:            OK
    testInMemOutdatedTimestamp:      OK (0.02s)
    testInMemIndex:                  OK
  HttpMem
    testHttpMemInitialHasForUpdates: OK
    testHttpMemNoUpdates:            OK
    testHttpMemUpdatesAfterCron:     OK
    testHttpMemKeyRollover:          OK (0.01s)
    testHttpMemOutdatedTimestamp:    OK (0.02s)
    testHttpMemIndex:                OK
  Canonical JSON
    prop_roundtrip_canonical:        OK (0.05s)
      +++ OK, passed 100 tests.
    prop_roundtrip_pretty:           OK (0.16s)
      +++ OK, passed 100 tests.
    prop_canonical_pretty:           OK (0.17s)
      +++ OK, passed 100 tests.
    prop_aeson_canonical:            OK (0.03s)
      +++ OK, passed 100 tests.

All 16 tests passed (0.52s)
Test suite TestSuite: PASS

[geekosaur]

I will note that, unless the test suite is cleverer than I think it is, this probably doesn't exercise anything being added in 3.16. But I'm not sure it's supposed to (e.g. what, if anything, does it do with SPDX?).

[Mikolaj]

Yeah, that's mostly a smoke test, which is good enough.

I guess @andreasabel's request has been satisified and there are no other objections, so I'm going to merge and revise today, as advertised.

[Mikolaj]

Doh, I didn't pay enough attention until I started revising on Hackage: shouldn't the second Cabal-syntax >= 3.7 && < 3.16 in hackage-security.cabal, the one for the test suite, be bumped as well? I assume so, so I've bumped it on Hackage, but we'd need to do so also in the repo:

Changes in this revision

    Changed the library component's library dependency on 'Cabal-syntax' from

    >=3.7 && <3.16

    to

    >=3.7 && <3.18

    Changed the test suite 'TestSuite' component's library dependency on 'Cabal' from

    >=3.7 && <3.16

    to

    >=3.7 && <3.18

    Changed the test suite 'TestSuite' component's library dependency on 'Cabal-syntax' from

    >=3.7 && <3.16

    to

    >=3.7 && <3.18

[Mikolaj]

BTW, I revised only hackage-security, as always, because only this one is needed for a cabal release.

[geekosaur]

#328