Skip to content

fix(load-balancer): wait for action of managed certificate#1144

Merged
apricote merged 1 commit intomainfrom
cert-action
Jan 30, 2026
Merged

fix(load-balancer): wait for action of managed certificate#1144
apricote merged 1 commit intomainfrom
cert-action

Conversation

@apricote
Copy link
Member

The action from creating the managed certificate was not awaited, which could cause issues where the creation fails, but this is not reported back on the Service. We now await the action and report its status back to the controller.

@apricote apricote self-assigned this Jan 30, 2026
@apricote apricote requested a review from a team as a code owner January 30, 2026 09:13
@apricote apricote added the bug Something isn't working label Jan 30, 2026
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.36%. Comparing base (f66b1ce) to head (4902825).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/hcops/certificates.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1144      +/-   ##
==========================================
- Coverage   68.40%   68.36%   -0.05%     
==========================================
  Files          23       23              
  Lines        2624     2627       +3     
==========================================
+ Hits         1795     1796       +1     
- Misses        655      656       +1     
- Partials      174      175       +1     
Flag Coverage Δ
e2e 44.01% <50.00%> (-0.02%) ⬇️
unit 64.75% <66.66%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apricote apricote merged commit 8045e96 into main Jan 30, 2026
10 checks passed
@apricote apricote deleted the cert-action branch January 30, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants