[4.2] Validate transaction and roll back them in case of error #2928
+275
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename variable "rollback" to "markedForRollback" * Change formattation
DavideD
added
bug
yrodiere
approved these changes
Dec 19, 2025
Member
yrodiere
left a comment
yrodiere
left a comment
There was a problem hiding this comment.
Thanks. Feel free to merge, but I have a few comments below -- especially about the behavior of beginTransaction...
Comment on lines
+110
to
+135
| assertThrown( IllegalStateException.class, getMutinySessionFactory() | ||
| .withTransaction( s -> s | ||
| .persist( beneath ) | ||
| .call( s::flush ) | ||
| // Close the connection before committing | ||
| .call( s::close ) | ||
| ) | ||
| ) | ||
| .invoke( e -> assertThat( e ) | ||
| .hasMessageContaining( "HR000090" ) | ||
| .hasMessageContaining( "closing the connection" ) | ||
| ) |
Member
There was a problem hiding this comment.
Could you assert that there is no active connection after this? Since that was the main problem :)
...reactive-core/src/test/java/org/hibernate/reactive/NoLiveTransactionValidationErrorTest.java
Show resolved
Hide resolved
hibernate-reactive-core/src/main/java/org/hibernate/reactive/pool/impl/SqlClientConnection.java
Outdated
Show resolved
Hide resolved
hibernate-reactive-core/src/main/java/org/hibernate/reactive/pool/impl/SqlClientConnection.java
Outdated
Show resolved
Hide resolved
hibernate-reactive-core/src/main/java/org/hibernate/reactive/pool/impl/SqlClientConnection.java
Outdated
Show resolved
Hide resolved
DavideD
force-pushed
the
2926-tx-rollback
branch
from
968dc36 to
234f0cd
Compare
There should not be any open transaction in progress when closing a connection. The risk is to leave open connections pending and exhaust the pool. Now, if the close operation detects an open transaction, it will roll back it and throw a validation error before closing the connection.
DavideD
force-pushed
the
2926-tx-rollback
branch
from
234f0cd to
ebd9ea5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2926
There are two places where we check if a transaction is already open:
SqlConnection#beginTransaction()andSqlConnection#close()The open transaction will be roll backed in both cases.
I wasn't sure how to recreate the Quarkus use case using only Hibernate Reactive, but I tested it locally and this solution fixes the problem.