-
Notifications
You must be signed in to change notification settings - Fork 107
refactor(examples): modularize transaction_to_bytes example (issue #1012) #1013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(examples): modularize transaction_to_bytes example (issue #1012) #1013
Conversation
|
[commit-verification-bot] To achieve verified status, please read: Remember, you require a GPG key and each commit must be signed with: Thank you for contributing! From the Hiero Python SDK Team |
|
Hi, this is WorkflowBot.
|
exploreriii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dantesb777
You have a signing error
https://github.com/hiero-ledger/hiero-sdk-python/pull/1013/commits
Your commits are not verified
recommend to soft revert (keep changes locally)
git reset --soft HEAD~1
then recommit
git commit -S -s -m "......"
pelase make sure you have set up the GPG key as explained in docs/sdk_developers/ signing.md
…ero-ledger#1012) Signed-off-by: dantesb777 <daniel199227@hotmail.com>
6cf13f4 to
ba774c1
Compare
|
Request review if available @tech0priyanshu @AntonioCeppellini |
|
Hi @tech0priyanshu @AntonioCeppellini 👋 My commits are now GPG signed and the requested changes have been addressed. Thank you! 🙌 |
exploreriii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dantesb777
Thank you for doing this
Yes, even i can't request those two reviewers using the form - have to investigate!
- Your commits are not verified- you have to set your GPG key on github please (see the commit tab)
- Please note what you have submitted -
https://github.com/hiero-ledger/hiero-sdk-python/pull/1013/files
There are 10 file changes added here, not just the transaction to bytes
Please I would recommend you start again
My suspicion is that your fork is not in sync with us
Please
There is a nice 'sync fork' button when you travel to your repo (you'll see it where the screenshot was taken), then just pull those chnages into main
You can read our rebase docuemntation to see how to do that
Thanks
|
I reviewed the screenshots you provided and applied the necessary fixes to address the issue. |
exploreriii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dantesb777
You have a key issue
You are submitting lots of changes to account create transaction
https://github.com/hiero-ledger/hiero-sdk-python/pull/1013/changes#diff-3e57aa7028a54d7dbc00ad02c44f84089a7bedc33d728afb113162c858c16032
this is not part of your issue that you are solving (transaction to bytes)
The reason why this may be happening if your fork is behind main
You must regularly follow docs/sdk_developers/rebasing.md to pull in recent changes from upstream main
You can see you are 11 commits behind main
https://github.com/dantesb777/hiero-sdk-python/tree/issue-1012-refactor-example
please click the sync fork button and then pull your changes to your branch
To be clear, the easiest thing is probably closing this PR, keeping this branch as backup, clicking the sync button, then starting again on a fresh branch from main and copy in only the changes you want to transaction to bytes.
We cannot approve this PR and there is a lot to fix
This PR refactors the transaction_to_bytes example to improve readability and modularity.
Related to: #1012