Skip to content

Conversation

@dantesb777
Copy link

This PR refactors the transaction_to_bytes example to improve readability and modularity.

  • Extracts logic into reusable functions
  • Adds validation and error messages
  • Improves naming consistency
  • Ensures the example follows the updated SDK structure

Related to: #1012

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

[commit-verification-bot]
Hi, this is VerificationBot.
Your pull request cannot be merged as it has unverified commits.
View your commit verification status: Commits Tab.

To achieve verified status, please read:

Remember, you require a GPG key and each commit must be signed with:
git commit -S -s -m "Your message here"

Thank you for contributing!

From the Hiero Python SDK Team

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Hi, this is WorkflowBot.
Your pull request cannot be merged as it is not passing all our workflow checks.
Please click on each check to review the logs and resolve issues so all checks pass.
To help you:

Copy link
Contributor

@exploreriii exploreriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dantesb777
You have a signing error
https://github.com/hiero-ledger/hiero-sdk-python/pull/1013/commits
Your commits are not verified

recommend to soft revert (keep changes locally)
git reset --soft HEAD~1

then recommit

git commit -S -s -m "......"

pelase make sure you have set up the GPG key as explained in docs/sdk_developers/ signing.md

@exploreriii exploreriii marked this pull request as draft December 9, 2025 10:10
@dantesb777 dantesb777 force-pushed the issue-1012-refactor-example branch from 6cf13f4 to ba774c1 Compare December 9, 2025 18:50
@dantesb777 dantesb777 marked this pull request as ready for review December 9, 2025 19:13
@exploreriii
Copy link
Contributor

Request review if available @tech0priyanshu @AntonioCeppellini

@dantesb777
Copy link
Author

Hi @tech0priyanshu @AntonioCeppellini 👋
I tried to add both of you as reviewers, but it seems I don't have the permissions to assign reviewers in this repository.

My commits are now GPG signed and the requested changes have been addressed.
Whenever you are available, could you please review my pull request?

Thank you! 🙌

Copy link
Contributor

@exploreriii exploreriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dantesb777
Thank you for doing this

Yes, even i can't request those two reviewers using the form - have to investigate!

  1. Your commits are not verified- you have to set your GPG key on github please (see the commit tab)
  2. Please note what you have submitted -
    https://github.com/hiero-ledger/hiero-sdk-python/pull/1013/files
    There are 10 file changes added here, not just the transaction to bytes

Please I would recommend you start again
My suspicion is that your fork is not in sync with us
Please
There is a nice 'sync fork' button when you travel to your repo (you'll see it where the screenshot was taken), then just pull those chnages into main
You can read our rebase docuemntation to see how to do that

Thanks

Image Image

@exploreriii exploreriii marked this pull request as draft December 10, 2025 04:46
@dantesb777 dantesb777 marked this pull request as ready for review December 11, 2025 05:22
@dantesb777
Copy link
Author

I reviewed the screenshots you provided and applied the necessary fixes to address the issue.
The updated code has been pushed. Please let me know if you need any further adjustments

Copy link
Contributor

@exploreriii exploreriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dantesb777
You have a key issue
You are submitting lots of changes to account create transaction
https://github.com/hiero-ledger/hiero-sdk-python/pull/1013/changes#diff-3e57aa7028a54d7dbc00ad02c44f84089a7bedc33d728afb113162c858c16032
this is not part of your issue that you are solving (transaction to bytes)

The reason why this may be happening if your fork is behind main
You must regularly follow docs/sdk_developers/rebasing.md to pull in recent changes from upstream main

You can see you are 11 commits behind main

Image

https://github.com/dantesb777/hiero-sdk-python/tree/issue-1012-refactor-example

please click the sync fork button and then pull your changes to your branch

Image

To be clear, the easiest thing is probably closing this PR, keeping this branch as backup, clicking the sync button, then starting again on a fresh branch from main and copy in only the changes you want to transaction to bytes.

We cannot approve this PR and there is a lot to fix

@exploreriii exploreriii marked this pull request as draft December 11, 2025 08:32
@dantesb777 dantesb777 closed this Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants