refactor(examples): modularize account_create_transaction_create_with_alias #1030
+117
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_alias (hiero-ledger#1016) Split monolithic create_account_with_separate_ecdsa_alias() into separate functions: - generate_main_and_alias_keys(): Generate main and ECDSA alias keys - create_account_with_ecdsa_alias(): Create account with the alias - fetch_account_info(): Query account information - print_account_summary(): Display account details These functions are now called from main() for better readability and maintainability. Signed-off-by: Aditya Shirsatrao <adityashirsatrao007@gmail.com> Signed-off-by: adityashirsatrao007 <adityashirsatrao007@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the account_create_transaction_create_with_alias.py example to improve code organization and maintainability by splitting a monolithic function into focused, single-responsibility functions.
Key Changes:
- Decomposed the single
create_account_with_separate_ecdsa_alias()function into four modular functions with clear responsibilities - Moved exception handling from individual functions to the main orchestrator function
- Added comprehensive docstrings with type hints for better code documentation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
examples/account/account_create_transaction_create_with_alias.py |
Refactored monolithic function into modular components: key generation, account creation, info fetching, and summary display |
CHANGELOG.md |
Added entry documenting the refactoring changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
examples/account/account_create_transaction_create_with_alias.py
Outdated
Show resolved
Hide resolved
examples/account/account_create_transaction_create_with_alias.py
Outdated
Show resolved
Hide resolved
examples/account/account_create_transaction_create_with_alias.py
Outdated
Show resolved
Hide resolved
- Add AccountInfo import - Add return type annotation to fetch_account_info - Add type annotation to print_account_summary parameter - Add newline to STEP 3 for consistent formatting Signed-off-by: adityashirsatrao007 <adityashirsatrao007@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Aditya <adityashirsatrao007@gmail.com>
Contributor
Author
|
I have refactored the example to modularize the code and added try-except blocks as requested. Renamed the key generation function to 'generate_main_and_alias_keys'. |
exploreriii
approved these changes
Dec 11, 2025
Contributor
|
Hi @adityashirsatrao007 great going thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the \�ccount_create_transaction_create_with_alias.py\ example to improve readability and maintainability.
Changes
Related Issue
Closes #1016
Checklist
Signed-off-by: Aditya Shirsatrao adityashirsatrao@gmail.com