Skip to content

fix: correct bot workflow YAML for draft PR handling #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tech0priyanshu wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: correct bot workflow YAML for draft PR handling #985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
482478f
fix: bot yml fixed for draft pr
tech0priyanshu Dec 7, 2025
35ce315
fix
tech0priyanshu Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/bot-verified-commits.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: PythonBot - Verify PR Commits

on:
pull_request_target:
types: [opened, synchronize]
types: [opened, synchronize, ready_for_review]

permissions:
contents: read
Expand All @@ -16,6 +16,7 @@ concurrency:
jobs:
verify-commits:
runs-on: ubuntu-latest
if: github.event.pull_request.draft == false

steps:
- name: Harden the runner (Audit all outbound calls)
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/merge-conflict-bot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: PythonBot - Check Merge Conflicts

on:
pull_request_target:
types: [opened, synchronize, reopened]
types: [opened, synchronize, reopened, ready_for_review]

permissions:
contents: read
Expand All @@ -15,6 +15,7 @@ concurrency:
jobs:
check-conflicts:
runs-on: ubuntu-latest
if: github.event.pull_request.draft == false

steps:
- name: Harden the runner (Audit all outbound calls)
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/pr-check-changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,15 @@ name: 'PR Changelog Check'
on:
workflow_dispatch:
pull_request:
types: [opened, reopened, edited, synchronize]
types: [opened, reopened, edited, synchronize, ready_for_review]

permissions:
contents: read

jobs:
changelog-check:
runs-on: ubuntu-latest
if: github.event_name == 'workflow_dispatch' || github.event.pull_request.draft == false
steps:
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
with:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/pr-check-title.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:
- reopened
- edited
- synchronize
- ready_for_review

defaults:
run:
Expand All @@ -25,7 +26,7 @@ jobs:
title-check:
name: Title Check
runs-on: ubuntu-latest
if: ${{ !github.event.pull_request.base.repo.fork }}
if: ${{ !github.event.pull_request.base.repo.fork && (github.event_name == 'workflow_dispatch' || github.event.pull_request.draft == false) }}
Copy link
Contributor

@exploreriii exploreriii Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same with this i think?

Copy link
Contributor

@exploreriii exploreriii Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but we do have bot workflows and bot verified commits which i would argue should only run on ready for review

debatable

permissions:
checks: write
statuses: write
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ This changelog is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.

### Added
- Added __str__() to CustomFixedFee and updated examples and tests accordingly.
- Added draft PR check to prevent bots from triggering on draft pull requests
- Added a github template for good first issues
- Added `.github/workflows/bot-assignment-check.yml` to limit non-maintainers to 2 concurrent issue assignments.
- Added all missing fields to __str__() method and updated `test_tokem_info.py`
Expand Down