Skip to content

Conversation

@prikhi
Copy link

@prikhi prikhi commented Dec 4, 2015

Before modifying the display property in the style property of an element, check that the style property exists. If it is undefined, assign an object with the display property to it.

This was causing an error on our site which prevented the map from loading.

@prikhi
Copy link
Author

prikhi commented Dec 20, 2015

@stephywells @jwahlin
Does strat11 have access to this repo? Is this plugin abandoned and should it be forked?

@jwahlin
Copy link

jwahlin commented Dec 22, 2015

This plugin was written by a third party and then abandoned by them. I think @hippychic was going to take a stab at keeping it updated, but that may have been abandoned as well.

If you want to fork it and take it over, that's fine with us. And since @hippychic hasn't responded, I'm guessing she would be fine with that too.

@hippychic
Copy link
Owner

Apologies to all, my father just passed away so I haven’t seen any other messages besides this one. Yes please have a go at it as I’m not in the right frame of mind right now. :)

From: Jamie Wahlin notifications@github.com
Reply-To: hippychic/formidable-geocoding reply@reply.github.com
Date: Tuesday, December 22, 2015 at 9:29 AM
To: hippychic/formidable-geocoding formidable-geocoding@noreply.github.com
Cc: Sabrina Carson sabrina@mnmsalem.com
Subject: Re: [formidable-geocoding] Check For Style Property Before Modifying (#7)

This plugin was written by a third party and then abandoned by them. I think @hippychic was going to take a stab at keeping it updated, but that may have been abandoned as well.

If you want to fork it and take it over, that's fine with us. And since @hippychic hasn't responded, I'm guessing she would be fine with that too.


Reply to this email directly or view it on GitHub.

@jwahlin
Copy link

jwahlin commented Dec 22, 2015

I'm sorry to hear about your father. Thanks for letting us know what the status is on this.

@prikhi
Copy link
Author

prikhi commented Dec 25, 2015

@hippychic Please take your time, I don't want to steal this project away from you, was only considering forking it because I thought it might've been abandoned. This PR isn't urgent, I'm fine with directly modifying our plugin code until you're available again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants