fix: git info check should not throw when debugging #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zone117x
force-pushed
the
feat/debugging-features
branch
from
2fcc62a to
13d4019
Compare
hirosystems-release-bot bot
added a commit
that referenced
this pull request
Jun 2, 2025
## [1.9.0](v1.8.0...v1.9.0) (2025-06-02) ### Features * onceWhen function ([#43](#43)) ([840b2f1](840b2f1)) * onceWhen function ([#43](#43)) ([#44](#44)) ([4013b38](4013b38)) * worker thread pool ([#41](#41)) ([16c9616](16c9616)) ### Bug Fixes * git info check should not throw when debugging ([#39](#39)) ([66f44d5](66f44d5))
Contributor
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The git-info script throws unwanted errors in certain debugging scenarios. It previously had an env var check for
NODE_ENV=testto avoid throwing in the context of tests, but this is often not set when debugging in other situations.This PR keeps that condition, and adds a new condition:
.git-infofile does not exist, and a debugger is not attached, then do not throw.This is implemented with a lazy-loaded function call and module-load after the
.git-infofile-not-found error:This PR also exposes this
isDebugginghelper function because that code is often useful in other projects that use this library.