Conversation
Signed-off-by: Son Nguyen <hoangson091104@gmail.com>
hoangsonww
added
documentation
There was a problem hiding this comment.
Pull Request Overview
Adds a GitHub Actions workflow to enforce code formatting and linting on pushes and pull requests.
- Introduces a CI/CD pipeline YAML defining formatting and a final status job.
- Configures triggers on the
masterbranch for push and pull_request events.
Comments suppressed due to low confidence (3)
.github/workflows/ci.yml:5
- The workflow only triggers on pushes and PRs to 'master', but if your default branch is named 'main', these events won't run. Consider updating to 'main' or adding both branch names.
branches: [master]
.github/workflows/ci.yml:16
- Using 'continue-on-error: true' for critical steps like checkout, setup-node, install, format, and lint suppresses failure signals. Remove these flags so the pipeline fails on errors.
continue-on-error: true
.github/workflows/ci.yml:10
- The CI pipeline currently only runs formatting and linting. Consider adding build and test jobs to ensure application functionality is validated in CI.
formatting:
Signed-off-by: Son Nguyen <hoangson091104@gmail.com>
Signed-off-by: Son Nguyen <hoangson091104@gmail.com>
Signed-off-by: Son Nguyen <hoangson091104@gmail.com>
Signed-off-by: Son Nguyen <hoangson091104@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.