Skip to content

Conversation

@NorthernMan54
Copy link

@NorthernMan54 NorthernMan54 commented Jul 6, 2025

Backlog

actions/create-release needs to be replaced

Breaking Change

Electron support has been removed, unless a tester can be found

@NorthernMan54 NorthernMan54 requested a review from Copilot July 6, 2025 04:50
@NorthernMan54 NorthernMan54 linked an issue Jul 6, 2025 that may be closed by this pull request
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR streamlines the build pipeline, drops legacy Debian 9 support, and adds Windows ARM64 build support.

  • Bumps package version and Node engine requirement to 20+
  • Removes the old Debian Dockerfile and tweaks Alpine build to constrain JOBS
  • Updates GitHub workflows to include Windows ARM runners and refactors the build matrix

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.json Version bump to 0.14.1 and requires Node ≥20.0.0
.prebuild/Dockerfile.oldDebian Removed outdated Debian 9 build recipe
.prebuild/Dockerfile.alpine Added ENV JOBS=1 to limit parallelism
.npmignore Ignoring deps/ and src/ to match published files
.github/workflows/Stage 2 - Validate.yml Expanded OS matrix (including Windows ARM), adjusted branches
.github/workflows/Prepare prebuild environment.yml Updated node targets and added Windows ARM prebuild step
.github/workflows/Alternate Approach.yml Refactored matrix for multi-platform builds and simplified steps
Comments suppressed due to low confidence (5)

package.json:55

  • Bumping the engines field to Node >=20 drops support for Node 18 and 19; please confirm this breaking change is intended or provide compatibility notes.
    "node": ">=20.0.0 <25.0.0"

.github/workflows/Alternate Approach.yml:126

  • The --platform flag was removed from the docker build command, which may cause incorrect builds on non-native targets. Reintroduce ${{ matrix.PLATFORM }} or an equivalent to ensure correct cross-platform builds.
          docker build -f .prebuild/${{ matrix.DOCKERFILE }} --build-arg BASE_IMAGE=${{ matrix.BASE_IMAGE }} --build-arg QEMU_ARCH=${{ matrix.QEMU_ARCH }} -t multiarch-build .

.github/workflows/Alternate Approach.yml:136

  • There's an unexpected tab/whitespace in runner.arch == 'X64' that may break YAML parsing. Replace with a single space before ==.
        if: ${{ (runner.os == 'macOS') && (runner.arch	 == 'X64') }}

.github/workflows/Stage 2 - Validate.yml:44

  • [nitpick] Including ubuntu-latest alongside explicit Ubuntu versions (ubuntu-24.04, ubuntu-22.04) duplicates runs since ubuntu-latest currently maps to ubuntu-22.04; consider removing redundancy.
        os: [ubuntu-latest, ubuntu-24.04, ubuntu-22.04, macos-latest, macos-15, macos-14, macos-13, windows-latest, windows-2025, windows-2022, windows-11-arm]

.github/workflows/Stage 2 - Validate.yml:44

  • windows-11-arm is not a standard GitHub Actions runner label; please verify runner availability or update to a supported label for ARM builds on Windows.
        os: [ubuntu-latest, ubuntu-24.04, ubuntu-22.04, macos-latest, macos-15, macos-14, macos-13, windows-latest, windows-2025, windows-2022, windows-11-arm]

@NorthernMan54 NorthernMan54 marked this pull request as draft July 6, 2025 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows arm64 Support

2 participants