-
Notifications
You must be signed in to change notification settings - Fork 17
Simplified and faster build process with Windows Arm Support #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR streamlines the build pipeline, drops legacy Debian 9 support, and adds Windows ARM64 build support.
- Bumps package version and Node engine requirement to 20+
- Removes the old Debian Dockerfile and tweaks Alpine build to constrain JOBS
- Updates GitHub workflows to include Windows ARM runners and refactors the build matrix
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Version bump to 0.14.1 and requires Node ≥20.0.0 |
| .prebuild/Dockerfile.oldDebian | Removed outdated Debian 9 build recipe |
| .prebuild/Dockerfile.alpine | Added ENV JOBS=1 to limit parallelism |
| .npmignore | Ignoring deps/ and src/ to match published files |
| .github/workflows/Stage 2 - Validate.yml | Expanded OS matrix (including Windows ARM), adjusted branches |
| .github/workflows/Prepare prebuild environment.yml | Updated node targets and added Windows ARM prebuild step |
| .github/workflows/Alternate Approach.yml | Refactored matrix for multi-platform builds and simplified steps |
Comments suppressed due to low confidence (5)
package.json:55
- Bumping the engines field to Node >=20 drops support for Node 18 and 19; please confirm this breaking change is intended or provide compatibility notes.
"node": ">=20.0.0 <25.0.0"
.github/workflows/Alternate Approach.yml:126
- The
--platformflag was removed from thedocker buildcommand, which may cause incorrect builds on non-native targets. Reintroduce${{ matrix.PLATFORM }}or an equivalent to ensure correct cross-platform builds.
docker build -f .prebuild/${{ matrix.DOCKERFILE }} --build-arg BASE_IMAGE=${{ matrix.BASE_IMAGE }} --build-arg QEMU_ARCH=${{ matrix.QEMU_ARCH }} -t multiarch-build .
.github/workflows/Alternate Approach.yml:136
- There's an unexpected tab/whitespace in
runner.arch == 'X64'that may break YAML parsing. Replace with a single space before==.
if: ${{ (runner.os == 'macOS') && (runner.arch == 'X64') }}
.github/workflows/Stage 2 - Validate.yml:44
- [nitpick] Including
ubuntu-latestalongside explicit Ubuntu versions (ubuntu-24.04,ubuntu-22.04) duplicates runs sinceubuntu-latestcurrently maps toubuntu-22.04; consider removing redundancy.
os: [ubuntu-latest, ubuntu-24.04, ubuntu-22.04, macos-latest, macos-15, macos-14, macos-13, windows-latest, windows-2025, windows-2022, windows-11-arm]
.github/workflows/Stage 2 - Validate.yml:44
windows-11-armis not a standard GitHub Actions runner label; please verify runner availability or update to a supported label for ARM builds on Windows.
os: [ubuntu-latest, ubuntu-24.04, ubuntu-22.04, macos-latest, macos-15, macos-14, macos-13, windows-latest, windows-2025, windows-2022, windows-11-arm]
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Backlog
actions/create-release needs to be replaced
Breaking Change
Electron support has been removed, unless a tester can be found