Fix WHERE clause subquery extraction in parse_table_names()#12
Closed
danielbodart wants to merge 1 commit intohotdata-dev:mainfrom
Closed
Fix WHERE clause subquery extraction in parse_table_names()#12danielbodart wants to merge 1 commit intohotdata-dev:mainfrom
danielbodart wants to merge 1 commit intohotdata-dev:mainfrom
Conversation
parse_table_names() was missing tables referenced in WHERE clause subqueries. For example: SELECT * FROM a WHERE x IN (SELECT y FROM b) Would only return ['a'], missing 'b'. This fix adds expression tree walking to extract subqueries from: - WHERE clause - SELECT list (scalar subqueries) - HAVING clause - QUALIFY clause - GROUP BY expressions - ORDER BY expressions - JOIN conditions Tables inside expression subqueries get 'subquery' context while tables in FROM clause subqueries keep their natural context. Co-Authored-By: Claude <noreply@anthropic.com>
Author
|
Closing - this fix was already implemented in PR #11. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_table_names()missing tables referenced in WHERE clause subqueriessubquerycontextExample
Test plan
🤖 Generated with Claude Code