Skip to content

[DuckDb v1.5.0] fix: update SetOperationNode API for DuckDB main branch #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
zfarrell wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[DuckDb v1.5.0] fix: update SetOperationNode API for DuckDB main branch #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions .github/workflows/MainDistributionPipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,10 @@ concurrency:
cancel-in-progress: true

jobs:
# TODO: Re-enable once compatible with DuckDB main (SetOperationNode API change)
# duckdb-next-build:
# name: Build extension binaries
# uses: duckdb/extension-ci-tools/.github/workflows/_extension_distribution.yml@main
# with:
# duckdb_version: main
# ci_tools_version: main
# extension_name: parser_tools

duckdb-stable-build:
duckdb-next-build:
name: Build extension binaries
uses: duckdb/extension-ci-tools/.github/workflows/_extension_distribution.yml@v1.4.4
uses: duckdb/extension-ci-tools/.github/workflows/_extension_distribution.yml@main
with:
duckdb_version: v1.4.4
ci_tools_version: v1.4.4
duckdb_version: main
ci_tools_version: main
extension_name: parser_tools
9 changes: 4 additions & 5 deletions src/parse_tables.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,11 +228,10 @@ static void ExtractTablesFromQueryNode(
else if (node.type == QueryNodeType::SET_OPERATION_NODE) {
auto &set_node = (SetOperationNode &)node;

if (set_node.left) {
ExtractTablesFromQueryNode(*set_node.left, results, context, cte_map);
}
if (set_node.right) {
ExtractTablesFromQueryNode(*set_node.right, results, context, cte_map);
for (auto &child : set_node.children) {
if (child) {
ExtractTablesFromQueryNode(*child, results, context, cte_map);
}
}
}

Expand Down
Loading