Merged
Conversation
This commit adds comprehensive function name extraction functionality: - New table function: parse_functions(sql_query) - New scalar functions: parse_function_names(sql_query), parse_functions(sql_query) - Extracts functions from all SQL contexts: SELECT, WHERE, HAVING, ORDER BY, GROUP BY - Supports window functions (e.g., row_number() OVER (...)) - Handles nested function calls with proper context tracking - Includes comprehensive test suite with 279 passing assertions - Follows DuckDB coding conventions and integrates with existing extension architecture 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add function parsing functions to overview and features - Document all three function parsing functions with examples - Add function context documentation (select, where, having, etc.) - Include usage examples showing window functions and filtering - Reorganize functions section with clear categories 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
zacMode
approved these changes
Jul 8, 2025
Collaborator
zacMode
left a comment
zacMode
left a comment
There was a problem hiding this comment.
nice, thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hope this is inline with your vision for this extension. I found your extension very useful and had a need to identify which functions existed or did not exist in a SQL statement. Thanks for making this!