[feat] Support Zero Bubble StreamRL-like RL Training#6356
Closed
YeAnbang wants to merge 6 commits intogrpo-latestfrom
Closed
[feat] Support Zero Bubble StreamRL-like RL Training#6356YeAnbang wants to merge 6 commits intogrpo-latestfrom
YeAnbang wants to merge 6 commits intogrpo-latestfrom
Conversation
YeAnbang
force-pushed
the
grpo-zero-bubble
branch
from
150ca20 to
509274c
Compare
YeAnbang
force-pushed
the
grpo-zero-bubble
branch
from
5acd219 to
e774ede
Compare
YeAnbang
force-pushed
the
grpo-zero-bubble
branch
from
65f5289 to
f067e77
Compare
TongLi3701
reviewed
Aug 4, 2025
Member
TongLi3701
left a comment
TongLi3701
left a comment
There was a problem hiding this comment.
Thanks Anbang, some comments.
Please also fully test each plugin and make sure it will not influence others.
Comment on lines
+118
to
+119
| def get_weight_version(self): | ||
| return min(self.weight_version) |
Member
There was a problem hiding this comment.
Seems that the weight version should be consistent, which means we need to make sure all chunks have the same version.
Member
There was a problem hiding this comment.
As you defined the length of the list is equal to pp size.
Contributor
Author
|
redirect to #6391 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Checklist before creating the PR
[doc/gemini/tensor/...]: A concise descriptionpip install pre-commit && pre-commit install🚨 Issue number
📝 What does this PR do?
💥 Checklist before requesting a review
⭐️ Do you enjoy contributing to Colossal-AI?
Tell us more if you don't enjoy contributing to Colossal-AI.