fix: wrong dp-rank condition when enable pp#6374
Open
liuqh16 wants to merge 116 commits intohpcaitech:mainfrom
Open
fix: wrong dp-rank condition when enable pp#6374liuqh16 wants to merge 116 commits intohpcaitech:mainfrom
liuqh16 wants to merge 116 commits intohpcaitech:mainfrom
Conversation
* [feature] fit rl style generation * [doc] add docstr * [doc] add docstr
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
[feat] Support Code Generation RFT, Move Reward Calculation to Producer
Co-authored-by: Tong Li <tong.li35271158@gmail.com>
Co-authored-by: Tong Li <tong.li35271158@gmail.com>
…achine [feat] Manually schedule resources and support auto master address assigning
…e_per_episode [fix] fix num update per episode
[Feat] optimize pp log_softmax memory usage
Co-authored-by: Tong Li <tong.li35271158@gmail.com>
…pcaitech#6353) * support n_behind, add profiling * fix bugs * fix visualization * fix behind * fix loop issue * add profiling * fix update * update assert * remove assert --------- Co-authored-by: Tong Li <tong.li35271158@gmail.com>
…-reward [fix] Grpo latest fix code reward
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Checklist before creating the PR
[doc/gemini/tensor/...]: A concise descriptionpip install pre-commit && pre-commit install🚨 Issue number
📝 What does this PR do?
Fix the wrong dp-rank condition when enable pp:
rl_examplewill raise anZeroDivisionErrorerror becauseself.accum_countonly accums whenself.dp_rank==0ingrpo_consumer.py.💥 Checklist before requesting a review
⭐️ Do you enjoy contributing to Colossal-AI?
Tell us more if you don't enjoy contributing to Colossal-AI.