Keyword pattern #63
Open
Keyword pattern #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the keyword pattern only accepted words with letters
[A-Za-z]and vowels with acute accents (only in the middle/end of the word, not at the beggining, due to how\hworks).This behaviour doesn't accept other languages written in latin alphabet, such as spanish (needs to accept ñ), or french (needs to accept ç, vowels with different kinds of accents).
This solution isn't ideal, as I think it ends up accepting more characters than needed (and also looking quite ugly), but I tested it and I don't notice any downside in its use.