Skip to content

fix: adjust enterprise api url for graphql use case #2180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Anonycoders wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −0
Open

fix: adjust enterprise api url for graphql use case #2180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/org/kohsuke/github/GitHub.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1285,6 +1285,7 @@ protected GHUser getUser(GHUser orig) {
@Nonnull
Requester createGraphQLRequest(String query) {
return createRequest().method("POST")
.withApiUrl(getApiUrl().replace("/api/v3", "/api"))
Copy link
Member

@bitwiseman bitwiseman Jan 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changed behavior isn't really tested by any existing test. Because of how it is written, code coverage doesn't catch it. On the plus side, we know this doesn't break the GitHub.com scenario, but we don't have any verification of the enterprise scenario.

Please add a test to the enterprise github tests that calls createGraphQLRequest and verifies the Requester has the new expected /api/graphql URL. You don't have actually make the http call, just check the value.

.rateLimit(RateLimitTarget.GRAPHQL)
.with("query", query)
.withUrlPath("/graphql");
Expand Down
Loading