[wip] feat: implement apply_lora_scale to remove boilerplate. #12994
+57
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently, we have this pattern throughout the modeling implementations:
IMO, this is not pretty and should possibly be minimized for a clean and self-contained implementation of the
forward().Hence, this PR introduces a decorator
apply_lora_scalethat can be used to decorate the forward method of a model supporting LoRA. I think this will help us reduce a bunch of boilerplate code.For keeping the PR simple, I have only applied the decorator to
src/diffusers/models/transformers/transformer_flux.pyThe LoRA tests for it are passing, indicating this direction might be a nice one.