-
Notifications
You must be signed in to change notification settings - Fork 6.7k
[GLM-Image] Add batch support for GlmImagePipeline #13007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JaredforReal
wants to merge
13
commits into
huggingface:main
Choose a base branch
from
JaredforReal:feat/glmimage-batch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+497
−134
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
10976ea
init
JaredforReal a071756
change from right padding to left padding
JaredforReal aa85e34
try i2i batch
JaredforReal b5a3ca1
fix: revert i2i prior_token_image_ids to original 1D tensor format
JaredforReal 5bba1a0
refactor KVCache for per prompt batching
JaredforReal f8384cb
fix KVCache
JaredforReal e665785
fix shape error
JaredforReal 26284e1
refactor pipeline
JaredforReal ff26259
fix for left padding
JaredforReal 9519239
insert seed to AR model
JaredforReal ada3f1d
delete generator, use torch manual_seed
JaredforReal 77bbeea
add batch processing unit tests for GlmImagePipeline
JaredforReal f83eb5c
Merge branch 'main' into feat/glmimage-batch
JaredforReal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The KV cache expansion logic doesn't match the
repeat_interleavesemantics used forprior_token_idsat line 943 of the pipeline. When expanding caches fornum_images_per_prompt > 1, the current code concatenates expanded caches sequentially (cache_0 repeated N times, then cache_1 repeated N times), butrepeat_interleaveproduces an interleaved pattern (cache_0, cache_0, cache_1, cache_1). This mismatch will cause incorrect cache retrieval. The expansion should userepeat_interleaveinstead ofexpand+cat, or use a similar interleaving pattern.