Skip to content

Conversation

@aspiers
Copy link
Contributor

@aspiers aspiers commented Jan 16, 2026

Replace separate pnpm build and pnpm test steps with pnpm check which runs lint, typecheck, build, and test together. Add comment explaining why checks run both here and in pnpm release.

Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com

Summary by CodeRabbit

  • Chores
    • Improved release pipeline to validate code integrity earlier in the process.

✏️ Tip: You can customize this high-level summary in your review settings.

Replace separate `pnpm build` and `pnpm test` steps with `pnpm check`
which runs lint, typecheck, build, and test together. Add comment
explaining why checks run both here and in `pnpm release`.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings January 16, 2026 22:37
@changeset-bot
Copy link

changeset-bot bot commented Jan 16, 2026

⚠️ No Changeset found

Latest commit: 980c87a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Jan 16, 2026

📝 Walkthrough

Walkthrough

The release workflow replaces initial build and test steps with an early pnpm check step that runs before release validation. This shifts the error-detection point earlier in the pipeline, enabling faster failure detection prior to versioning and git operations.

Changes

Cohort / File(s) Summary
CI Workflow Configuration
.github/workflows/release.yml
Removed pnpm build and pnpm test steps; added pnpm check step before release validation. Reorders execution to detect issues earlier and prevent failures after version/git changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Poem

🐰 Checks hop before the release gate,
Fast failure, no time to wait,
Reordered steps with early might,
Catching bugs before the night! 🌙✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: consolidating separate build and test steps into a single pnpm check step in the CI/release workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates early CI checks in the release workflow by replacing separate pnpm build and pnpm test steps with a unified pnpm check command. This ensures comprehensive validation (format, lint, typecheck, build, and test) occurs before any versioning or git operations, with explanatory comments about the intentional redundancy with checks in pnpm release.

Changes:

  • Replaced individual pnpm build and pnpm test steps with pnpm check
  • Added explanatory comments about the fail-fast strategy and intentional check redundancy

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aspiers aspiers merged commit 906aeba into hypercerts-org:develop Jan 17, 2026
9 checks passed
@aspiers aspiers deleted the fix/release-checks branch January 17, 2026 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant