Implement RAM storage, fix port aliasing using -p switch#16
Open
tomasol wants to merge 1 commit intohypercore-protocol:masterfrom
Open
Implement RAM storage, fix port aliasing using -p switch#16tomasol wants to merge 1 commit intohypercore-protocol:masterfrom
tomasol wants to merge 1 commit intohypercore-protocol:masterfrom
Conversation
tomasol
force-pushed
the
fix-memory-only
branch
from
7ec15c6 to
dc57bfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
--memory-onlybeing ignored. Addedrandom-access-memorystorage when the switch is passed. In any case, a logging message now informs the user about the selected storage backend.Also fixed an unrelated bug -
-pswitch was ignored as well, because there was a missing alias for the shortcut.