Fix issue with where clause missing on AI Graph Explorer Responses #1613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix was to correct the types with the server (so server->app is strongly typed). Sever sends no where clause, but previously frontend was typed to expect where clause. This PR also ports some changes from ee to oss to avoid drift between the projects
brandon-pereira
requested review from
a team and
knudtty
and removed request for
a team
🦋 Changeset detectedLatest commit: 5142508 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandon-pereira
commented
Jan 15, 2026
| { | ||
| onSuccess(data) { | ||
| setConfig(data); | ||
| setConfig({ ...data, where: '' }); |
Member
Author
There was a problem hiding this comment.
This was the actual fix for the issue, but I fixed it by improving the types
PR Review - AI Graph Explorer Type Safety FixCritical Issues✅ No critical issues found. Important ObservationsType Safety Improvements:
Code Organization:
Minor Observations:
Schema Design:
RecommendationApprove - The PR successfully fixes the type mismatch bug that caused crashes. Type safety improvements are solid and error handling is appropriate. |
Contributor
E2E Test Results✅ All tests passed • 61 passed • 4 skipped • 748s
Tests ran across 4 shards in parallel. |
knudtty
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when generating charts, the page would crash.
The fix was to correct the types with the server (so server->app is strongly typed). Sever still sends no where clause, but previously frontend was typed to expect where clause.
This PR also ports some changes from ee to oss to avoid drift between the projects
Fixes HDX-3227