Skip to content

Conversation

@karl-power
Copy link
Contributor

Follow up to #1576 after feedback from @MikeShi42.

With these changes, validation queries run either when the "Validate expression" button is clicked, or 1 second after the input value was changed for either the expression or the alias.

Untitled.mov

@changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2026

🦋 Changeset detected

Latest commit: 1d24bb2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview, Comment Jan 22, 2026 2:17pm

Request Review

@claude
Copy link

claude bot commented Jan 20, 2026

PR Review

✅ No critical issues found.

The implementation correctly debounces the validation query with a 1-second delay and uses useDidUpdate to skip validation on mount. The logic for showing validation results is properly controlled via shouldShowResult to prevent stale results from appearing.

Minor observations (non-blocking):

  • The debounced validation pattern is clean and follows Mantine hooks best practices
  • Query caching is properly configured via TanStack Query (enabled flag controls execution)
  • The shouldShowResult check ensures validation feedback matches current input state

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

E2E Test Results

All tests passed • 59 passed • 4 skipped • 771s

Status Count
✅ Passed 59
❌ Failed 0
⚠️ Flaky 2
⏭️ Skipped 4

Tests ran across 4 shards in parallel.

View full report →

@karl-power karl-power requested review from a team and pulpdrew and removed request for a team January 22, 2026 09:28
@fleon fleon self-requested a review January 22, 2026 09:56
fleon
fleon previously approved these changes Jan 22, 2026
Copy link
Contributor

@fleon fleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Though my preference is to have a shorter debounce interval, say 400-500ms, its not a strong preference.

pulpdrew
pulpdrew previously approved these changes Jan 22, 2026
Copy link
Contributor

@pulpdrew pulpdrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice improvement!

@karl-power karl-power dismissed stale reviews from pulpdrew and fleon via 1d24bb2 January 22, 2026 14:14
@karl-power karl-power force-pushed the karl/debounce-highlighted-attribute-validation branch from 4982ef5 to 1d24bb2 Compare January 22, 2026 14:14
@karl-power karl-power requested a review from pulpdrew January 22, 2026 14:42
@kodiakhq kodiakhq bot merged commit 3a2c33d into main Jan 22, 2026
16 of 17 checks passed
@kodiakhq kodiakhq bot deleted the karl/debounce-highlighted-attribute-validation branch January 22, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants