Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

Conversation

@mattjohnsonpint
Copy link
Contributor

@mattjohnsonpint mattjohnsonpint commented Apr 3, 2025

#807 broke the linter workflows. These changes are as a direct result.

  • Ensure all workflows with path filters include the workflow file. That would have caught this in the checks for chore(deps): Update golangci/golangci-lint-action action to v7 #807 itself.
  • Add a config file for golangci-lint. Put it in the Trunk configs dir, so Trunk will use it also.
  • Address remaining linter warnings coming out of the new golangci-lint
  • Update Trunk and all Trunk plugins to latest.

Note that Trunk is still using v1 of golangci-lint. When it updates to v2, then I'll remove the separate linting workflows and we can just use Trunk alone.

@mattjohnsonpint mattjohnsonpint requested review from a team and Copilot April 3, 2025 22:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 26 out of 26 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

sdk/go/pkg/graphql/graphql.go:32

  • [nitpick] The error message now starts with a lower-case letter; please confirm that this formatting style is consistently applied across the codebase according to our guidelines.
return nil, errors.New("failed to execute the GQL query")

@mattjohnsonpint mattjohnsonpint enabled auto-merge (squash) April 3, 2025 23:02
@mattjohnsonpint mattjohnsonpint merged commit dfb8b89 into main Apr 3, 2025
109 checks passed
@mattjohnsonpint mattjohnsonpint deleted the mjp/misc branch April 3, 2025 23:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants