Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

Conversation

@mattjohnsonpint
Copy link
Contributor

Description

There are three paths that a Modus SDK can be installed via the CLI:

  • Explicitly via modus sdk install
  • Automatically during modus build
  • Automatically during the build phase of modus dev

The first two were correct, but the latter was not installing the modus-go-build tool.

Fixed by:

  • reused the install command in modus dev, just like modus build was doing already
  • added a check to repair via reinstall if the modus-go-build tool is missing

Checklist

All PRs should check the following boxes:

  • I have given this PR a title using the
    Conventional Commits syntax, leading with fix:,
    feat:, chore:, ci:, etc.
    • The title should also be used for the commit message when the PR is squashed and merged.
  • I have formatted and linted my code with Trunk, per the instructions in
    the contributing guide.

If the PR includes a code change, then also check the following boxes. (If not, then delete the
next section.)

  • I have added an entry to the CHANGELOG.md file.
    • Add to the "UNRELEASED" section at the top of the file, creating one if it doesn't yet exist.
    • Be sure to include the link to this PR, and please sort the section numerically by PR number.
  • I have manually tested the new or modified code, and it appears to behave correctly.
  • I have added or updated unit tests where appropriate, if applicable.

@mattjohnsonpint mattjohnsonpint requested review from a team and Copilot May 6, 2025 18:10
@linear
Copy link

linear bot commented May 6, 2025

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue with the installation of the Go SDK in dev mode by ensuring the modus-go-build tool is correctly installed. The changes include an enhanced check in sdkVersionIsInstalled for the Go build tool, refactoring the dev command to reuse the SDK install command, and updating the changelog.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
cli/src/util/versioninfo.ts Adds an extra check for the Go build tool and cleans up incomplete installs
cli/src/commands/dev/index.ts Refactors SDK installation logic to reuse the shared SDKInstallCommand
CHANGELOG.md Documents the fix in the changelog

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@mattjohnsonpint mattjohnsonpint merged commit 7d849a9 into main May 6, 2025
6 checks passed
@mattjohnsonpint mattjohnsonpint deleted the mjp/hyp-3296-modus-go-build-tool-is-not-installed branch May 6, 2025 18:12
Copilot AI mentioned this pull request May 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants