This repository was archived by the owner on Sep 11, 2025. It is now read-only.
fix: pass pre-release flags properly to subcommands #847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that the pre-release flag is properly passed to subcommands for the "new" and "dev" commands, addressing issues with SDK installation and runtime version retrieval when dealing with pre-release SDK versions.
- In the "new" command, the pre-release flag is now conditionally appended to the SDK installation arguments.
- In the "dev" command, the pre-release check is unified into a single variable and used consistently when determining runtime versions.
- The CHANGELOG has been updated to document the changes in version 0.18.0.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cli/src/commands/new/index.ts | Updated to conditionally forward "--prerelease" to the SDK install subcommand. |
| cli/src/commands/dev/index.ts | Unified pre-release flag usage for runtime version checks. |
| CHANGELOG.md | Added changelog entry for the fix. |
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
Contributor
Author
|
found another cli thing.... hold this for now |
ryanfoxtyler
approved these changes
May 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modus new --prereleaseshould forward the pre-release flag to the sdk install subcommand when neededmodus devshould not require--prereleaseif the app is already using a pre-release SDK versionVersioning this as
0.18.0to align with current cycle