Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

Conversation

@mattjohnsonpint
Copy link
Contributor

Fixed a CLI issue where modus build or modus dev on a pre-release version update would give this error:

image

Also updated dependencies and adjusted code to match.

@mattjohnsonpint mattjohnsonpint requested review from a team and Copilot June 12, 2025 18:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

A PR to repair a runtime prerelease matching bug and update dependency versions to ensure smoother CLI operations.

  • Ensure OS architecture is consistently handled as a string.
  • Update the runtime prerelease determination logic to correctly account for both flag and version prerelease conditions.
  • Bump dependency versions and update the CHANGELOG accordingly.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

File Description
cli/src/util/installer.ts Converted os.arch() to string for consistency with OS platform handling.
cli/src/commands/sdk/install/index.ts Updated runtime prerelease logic to merge flags and version prerelease checks.
cli/package.json Upgraded dependency versions to new releases.
CHANGELOG.md Documented the bug fix and dependency updates in the changelog.
Comments suppressed due to low confidence (1)

cli/src/commands/sdk/install/index.ts:75

  • [nitpick] Consider adding a brief comment to clarify why the runtimePrerelease flag is determined by combining flags.prerelease and the prerelease status of args.version. This can improve future maintainability.
const runtimePrerelease = flags.prerelease || (!!args.version && vi.isPrerelease(args.version));

@mattjohnsonpint mattjohnsonpint enabled auto-merge (squash) June 12, 2025 18:06
@mattjohnsonpint mattjohnsonpint merged commit 1d1324e into main Jun 12, 2025
5 of 7 checks passed
@mattjohnsonpint mattjohnsonpint deleted the mjp/cli branch June 12, 2025 18:07
@mattjohnsonpint mattjohnsonpint restored the mjp/cli branch June 12, 2025 18:07
@mattjohnsonpint mattjohnsonpint deleted the mjp/cli branch June 12, 2025 18:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants